Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issue 1897163002: Remove ENABLE(INPUT_MULTIPLE_FIELDS_UI) conditional compilation in platform/. (Closed)

Created:
4 years, 8 months ago by tkent
Modified:
4 years, 8 months ago
Reviewers:
keishi
CC:
blink-reviews, chromium-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ENABLE(INPUT_MULTIPLE_FIELDS_UI) conditional compilation in platform/. This CL has no code change on non-Android, but adds some dead code on Android. BUG=243714 Committed: https://crrev.com/57c5fa21f7bacf5645109e1613d9cfc0bf116b83 Cr-Commit-Position: refs/heads/master@{#388155}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M third_party/WebKit/Source/platform/text/DateTimeFormatTest.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/text/LocaleICUTest.cpp View 4 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/text/LocaleMacTest.cpp View 4 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/text/LocaleWinTest.cpp View 4 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/text/PlatformLocale.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/text/PlatformLocale.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tkent
Keishi, would you review this please? no hurry.
4 years, 8 months ago (2016-04-19 06:25:40 UTC) #2
keishi
LGTM
4 years, 8 months ago (2016-04-19 07:20:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897163002/1
4 years, 8 months ago (2016-04-19 07:22:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 07:26:40 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 07:28:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57c5fa21f7bacf5645109e1613d9cfc0bf116b83
Cr-Commit-Position: refs/heads/master@{#388155}

Powered by Google App Engine
This is Rietveld 408576698