Make SQL in DownloadDatabase SQLite pre 3.8.3 compatible

components/history/core/browser/download_database.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/history/core/browser/download_database.h"
 
+#include <inttypes.h>
+
 #include <limits>
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/debug/alias.h"
 #include "base/files/file_path.h"
 #include "base/metrics/histogram.h"
+#include "base/rand_util.h"
 #include "base/stl_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
 #include "components/history/core/browser/download_constants.h"
 #include "components/history/core/browser/download_row.h"
 #include "components/history/core/browser/history_types.h"
 #include "sql/statement.h"
 
@@ skipping 206 matching lines @@
   // This GUID generation scheme is only used for migrated download rows and
   // assumes that the likelihood of a collision with a GUID generated via
   // base::GenerateGUID() will be vanishingly small.
   //
   // A previous version of this code generated GUIDs that used random bits for
   // all but the first 32-bits. I.e. the scheme didn't respect the 6 fixed bits
   // as prescribed for type 4 GUIDs. The resulting GUIDs are not believed to
   // have an elevated risk of collision with GUIDs generated via
   // base::GenerateGUID() and are considered valid by all known consumers. Hence
   // no additional migration logic is being introduced to fix those GUIDs.
-  const char kMigrateGuidsQuery[] =
-      "UPDATE downloads SET guid = printf"
-      "(\"%08X-%s-4%s-%01X%s-%s\","
-      " id,"
-      " hex(randomblob(2)),"
-      " substr(hex(randomblob(2)),2),"
-      " (8 | (random() & 3)),"
-      " substr(hex(randomblob(2)),2),"
-      " hex(randomblob(6)))";
-  return GetDB().Execute(kMigrateGuidsQuery);
+  sql::Statement select(GetDB().GetUniqueStatement("SELECT id FROM downloads"));
+  sql::Statement update(
+      GetDB().GetUniqueStatement("UPDATE downloads SET guid = ? WHERE id = ?"));
+  while (select.Step()) {
+    uint32_t id = select.ColumnInt(0);
+    uint64_t r1 = base::RandUint64();
+    uint64_t r2 = base::RandUint64();
+    std::string guid = base::StringPrintf(
+        "%08" PRIX32 "-%04" PRIX64 "-4%03" PRIX64 "-%04" PRIX64 "-%012" PRIX64,
+        id, r1 >> 48,
+        (r1 >> 36) & 0xfff,
+        ((8 | ((r1 >> 34) & 3)) << 12) | ((r1 >> 22) & 0xfff),
+        r2 & 0xffffffffffff);
+    update.BindString(0, guid);
+    update.BindInt(1, id);
+    if (!update.Run())
+      return false;
+    update.Reset(true);
+  }
+  return true;
 }
 
 bool DownloadDatabase::MigrateDownloadTabUrl() {
   return EnsureColumnExists("tab_url", "VARCHAR NOT NULL DEFAULT ''") &&
          EnsureColumnExists("tab_referrer_url", "VARCHAR NOT NULL DEFAULT ''");
 }
 
 bool DownloadDatabase::InitDownloadTable() {
   const char kSchema[] =
       "CREATE TABLE downloads ("
@@ skipping 399 matching lines @@
 size_t DownloadDatabase::CountDownloads() {
   EnsureInProgressEntriesCleanedUp();
 
   sql::Statement statement(GetDB().GetCachedStatement(SQL_FROM_HERE,
       "SELECT count(*) from downloads"));
   statement.Step();
   return statement.ColumnInt(0);
 }
 
 }  // namespace history