Convert cpplint.py to work with nested git repositories.

Convert cpplint.py to work with nested git repositories.

Chrome on iOS downstream repository tracks Chromium via DEPS and wants
to use cpplint canned presubmit check but the cpplint.py errors due at
the include guard as it stops at the inner most git repository.

Change cpplint.py to look for the outermost git repository when looking
for the repository root.

BUG=598090
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300085

[sdefresne, 2016-04-19 16:27:24]

sdefresne@chromium.org changed reviewers:
+ iannucci@chromium.org

[sdefresne, 2016-04-19 16:27:24]

Please take a look.

[iannucci, 2016-04-19 17:01:14]

iannucci@chromium.org changed reviewers:
+ skym@chromium.org

[iannucci, 2016-04-19 17:01:15]

+someone who's actually ever looked at this file

[iannucci, 2016-04-19 17:02:19]

but other than that lgtm

[skym, 2016-04-20 18:52:13]

lgtm

[sdefresne, 2016-04-21 08:25:46]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-21 08:25:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1897153003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1897153003/1

[commit-bot: I haz the power, 2016-04-21 08:28:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 08:28:05]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2016-04-21 16:57:39]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-04-21 16:57:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1897153003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1897153003/1

[commit-bot: I haz the power, 2016-04-21 17:00:22]

Description was changed from

==========
Convert cpplint.py to work with nested git repositories.

Chrome on iOS downstream repository tracks Chromium via DEPS and wants
to use cpplint canned presubmit check but the cpplint.py errors due at
the include guard as it stops at the inner most git repository.

Change cpplint.py to look for the outermost git repository when looking
for the repository root.

BUG=598090
==========

to

==========
Convert cpplint.py to work with nested git repositories.

Chrome on iOS downstream repository tracks Chromium via DEPS and wants
to use cpplint canned presubmit check but the cpplint.py errors due at
the include guard as it stops at the inner most git repository.

Change cpplint.py to look for the outermost git repository when looking
for the repository root.

BUG=598090

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300085
==========

[commit-bot: I haz the power, 2016-04-21 17:00:23]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300085

[Raphael Kubo da Costa (rakuco), 2016-04-22 09:46:14]

Commenting here since I don't have access to the bug.

This broke our (Crosswalk) downstream repositories: we run
presubmit_canned_checks.CheckChangeLintsClean() on patch submission, and our
checkout is done inside a Buildbot repository, so now RepositoryName() returns a
path starting at the Buildbot repository root directory. This has since been
worked around in our PRESUBMIT.py code, but I can see it potentially breaking
things for other users too.

FWIW, we had the same problem described in the CL description, and at the time I
worked around it by doing something like this:

def MyCheckChangeLintsClean(input_api, output_api):
  class PrefixedFileInfo(cpplint.FileInfo):
    return 'chrome/' + super(PrefixedFileInfo, self).RepositoryName()
  input_api.cpplint.FileInfo = PrefixedFileInfo
  source_filter = ...
  return input_api.canned_checks.CheckChangeLintsClean(
    input_api, output_api, source_filter)

[Raphael Kubo da Costa (rakuco), 2016-04-22 09:47:06]

On 2016/04/22 09:46:14, Raphael Kubo da Costa (rakuco) wrote:
>     return 'chrome/' + super(PrefixedFileInfo, self).RepositoryName()

'chrome/' was only an example there, of course.

[kjellander_chromium, 2016-04-22 19:26:18]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1919483002/ by kjellander@chromium.org.

The reason for reverting is: This breaks WebRTC presubmit on the buildbots (due
to /b/build being a Git repo, which in turn contains the checkout). See 
https://bugs.chromium.org/p/webrtc/issues/detail?id=5818 for more details.

It seems it also broke other projects (rakuco's comment #15).

.