Declare dependency on blink_headers in targets that use blink headers

Declare dependency on blink_headers in targets that use blink headers

This updates targets that use blink public API headers to depend on the
blink_headers target, which sets up include paths so the headers can function
without needing relative path hacks. Targets that expose #includes of public
blink headers export the dependent settings from blink_headers to their
dependents.

BUG=350097
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257357

[jamesr, 2014-03-07 01:24:06]

jam@ - please review content/*gyp
sky@ - please review chrome/*gyp
joi@ - please review components/*gyp
bbudge@ - please review ppapi/ppapi_proxy_nacl.gyp

The goal of this patch is to make it so that all targets in the repo that depend
on blink headers have a dependency relationship in GYP so we can set up the
include dir for them correctly, and in the future any other configuration the
headers might need.  Not having this has made working with the blink public
headers very annoying as depending on how a given header is exposed through
#includes in chromium side the rules for what sort of #include paths work are
inconsistent.

[jamesr, 2014-03-07 01:24:14]

This depends on https://codereview.chromium.org/189393003/

[bbudge, 2014-03-07 02:06:37]

Thanks for sorting the dependencies in ppapi. LGTM

[bbudge, 2014-03-07 02:07:33]

https://codereview.chromium.org/189713002/diff/1/ppapi/ppapi_proxy_nacl.gyp
File ppapi/ppapi_proxy_nacl.gyp (right):

https://codereview.chromium.org/189713002/diff/1/ppapi/ppapi_proxy_nacl.gyp#n...
ppapi/ppapi_proxy_nacl.gyp:44:
'../third_party/khronos/khronos.gyp:khronos_headers',
Oh, just noticed this one is out of order.

[jamesr, 2014-03-07 02:08:59]

https://codereview.chromium.org/189713002/diff/1/ppapi/ppapi_proxy_nacl.gyp
File ppapi/ppapi_proxy_nacl.gyp (right):

https://codereview.chromium.org/189713002/diff/1/ppapi/ppapi_proxy_nacl.gyp#n...
ppapi/ppapi_proxy_nacl.gyp:44:
'../third_party/khronos/khronos.gyp:khronos_headers',
On 2014/03/07 02:07:33, bbudge wrote:
> Oh, just noticed this one is out of order.

I don't think so - uppercase letters sort before lowercase letters, at least in
my 'sort'. do we do case-insensitve sorts elsewhere?

[bbudge, 2014-03-07 02:20:21]

https://codereview.chromium.org/189713002/diff/1/ppapi/ppapi_proxy_nacl.gyp
File ppapi/ppapi_proxy_nacl.gyp (right):

https://codereview.chromium.org/189713002/diff/1/ppapi/ppapi_proxy_nacl.gyp#n...
ppapi/ppapi_proxy_nacl.gyp:44:
'../third_party/khronos/khronos.gyp:khronos_headers',
On 2014/03/07 02:09:00, jamesr wrote:
> On 2014/03/07 02:07:33, bbudge wrote:
> > Oh, just noticed this one is out of order.
> 
> I don't think so - uppercase letters sort before lowercase letters, at least
in
> my 'sort'. do we do case-insensitve sorts elsewhere?

You're right. My excuse is the shuttle is bouncing.

[sky, 2014-03-07 02:38:10]

LGTM

[Jói, 2014-03-07 13:10:40]

//components LGTM

[jam, 2014-03-07 18:38:46]

lgtm

[jamesr, 2014-03-11 22:39:22]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-03-11 22:51:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/189713002/1

[commit-bot: I haz the power, 2014-03-12 05:02:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-12 05:02:55]

Retried try job too often on ios_rel_device for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_de...

[jamesr, 2014-03-12 05:20:08]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-03-12 05:22:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/189713002/1

[commit-bot: I haz the power, 2014-03-12 05:52:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-12 05:52:53]

Retried try job too often on ios_dbg_simulator for step(s) base_unittests,
compile, components_unittests, content_unittests, crypto_unittests,
net_unittests, sql_unittests, ui_unittests, url_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[jamesr, 2014-03-14 21:02:42]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-03-14 21:03:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/189713002/20001

[commit-bot: I haz the power, 2014-03-14 21:04:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-14 21:04:07]

Failed to apply patch for content/content_ppapi_plugin.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/content_ppapi_plugin.gypi
  Hunk #1 FAILED at 11.
  1 out of 1 hunk FAILED -- saving rejects to file
content/content_ppapi_plugin.gypi.rej

Patch:       content/content_ppapi_plugin.gypi
Index: content/content_ppapi_plugin.gypi
diff --git a/content/content_ppapi_plugin.gypi
b/content/content_ppapi_plugin.gypi
index
60107db351b680ddf310de304698167cc6e2703d..0379f4f2ae86a44ede12fa138c11f6df490d7e7d
100644
--- a/content/content_ppapi_plugin.gypi
+++ b/content/content_ppapi_plugin.gypi
@@ -11,6 +11,7 @@
         '../ui/gfx/gfx.gyp:gfx',
         '../ui/gfx/gfx.gyp:gfx_geometry',
         '../ui/ui.gyp:ui',
+        '../third_party/WebKit/public/blink.gyp:blink',
       ],
       'sources': [
         'ppapi_plugin/broker_process_dispatcher.cc',

[jamesr, 2014-03-14 21:26:24]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-03-14 21:27:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/189713002/40001

[commit-bot: I haz the power, 2014-03-14 21:40:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-14 21:40:13]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_rel

[jamesr, 2014-03-14 21:42:29]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-03-14 21:44:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/189713002/60001

[commit-bot: I haz the power, 2014-03-14 21:47:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-14 21:47:55]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_clang_dbg

[jamesr, 2014-03-15 00:36:55]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-03-15 00:37:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/189713002/80001

[commit-bot: I haz the power, 2014-03-15 00:40:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-15 00:40:47]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_clang_dbg

[jamesr, 2014-03-15 22:14:29]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-03-15 22:14:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/189713002/80001

[commit-bot: I haz the power, 2014-03-15 23:00:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-15 23:00:41]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[jamesr, 2014-03-15 23:19:51]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-03-15 23:20:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/189713002/80001

[commit-bot: I haz the power, 2014-03-16 04:43:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/189713002/80001

[commit-bot: I haz the power, 2014-03-16 05:05:32]

Change committed as 257357

[jochen (gone - plz use gerrit), 2014-03-16 16:06:22]

https://codereview.chromium.org/189713002/diff/80001/components/nacl.gyp
File components/nacl.gyp (right):

https://codereview.chromium.org/189713002/diff/80001/components/nacl.gyp#newc...
components/nacl.gyp:406: '../content/content.gyp:content_common',
note that this appears to break linking on chromeos. Sadly, link warnings on
chromeos aren't treated as errors on the buildbots, so it didn't prevent the CQ
from committing :-/

[jamesr, 2014-03-16 17:58:48]

Can you link me to the failure?
On Mar 16, 2014 9:06 AM, <jochen@chromium.org> wrote:

>
> https://codereview.chromium.org/189713002/diff/80001/components/nacl.gyp
> File components/nacl.gyp (right):
>
> https://codereview.chromium.org/189713002/diff/80001/
> components/nacl.gyp#newcode406
> components/nacl.gyp:406: '../content/content.gyp:content_common',
> note that this appears to break linking on chromeos. Sadly, link
> warnings on chromeos aren't treated as errors on the buildbots, so it
> didn't prevent the CQ from committing :-/
>
> https://codereview.chromium.org/189713002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jochen (gone - plz use gerrit), 2014-03-16 23:08:04]

e.g.
http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...
(search for gold64)

[jochen (gone - plz use gerrit), 2014-03-16 23:17:46]

On 2014/03/16 23:08:04, jochen wrote:
> e.g.
>
http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...
> (search for gold64)

Do you think you can easily fix that? Otherwise, can we revert?

I'd like to land a change to make linker errors a tree closer on all platforms

[jamesr, 2014-03-17 05:41:13]

Those look identical to other linker errors generated by different parts of
the nacl build, e.g.:

https://code.google.com/p/chromium/issues/detail?id=351057

I don't think the underlying problem is new to this patch.  The gyp changes
here are correct, I believe - components/nacl does depend on the content
library and should declare a dependency.  If you would like to fix the nacl
build to be warning free please go ahead but don't revert this patch.


On Sun, Mar 16, 2014 at 4:17 PM, <jochen@chromium.org> wrote:

> On 2014/03/16 23:08:04, jochen wrote:
>
>> e.g.
>>
>
> http://build.chromium.org/p/tryserver.chromium/builders/
> linux_chromium_chromeos_clang_dbg/builds/4438/steps/compile%
> 2520%2528with%2520patch%2529/logs/stdio
>
>> (search for gold64)
>>
>
> Do you think you can easily fix that? Otherwise, can we revert?
>
> I'd like to land a change to make linker errors a tree closer on all
> platforms
>
> https://codereview.chromium.org/189713002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jochen (gone - plz use gerrit), 2014-03-17 06:44:57]

On 2014/03/17 05:41:13, jamesr wrote:
> Those look identical to other linker errors generated by different parts of
> the nacl build, e.g.:
> 
> https://code.google.com/p/chromium/issues/detail?id=351057
> 
> I don't think the underlying problem is new to this patch.  The gyp changes
> here are correct, I believe - components/nacl does depend on the content
> library and should declare a dependency.  If you would like to fix the nacl
> build to be warning free please go ahead but don't revert this patch.

All those warnings where introduced by your patch. Before, there were none.

> 
> 
> On Sun, Mar 16, 2014 at 4:17 PM, <mailto:jochen@chromium.org> wrote:
> 
> > On 2014/03/16 23:08:04, jochen wrote:
> >
> >> e.g.
> >>
> >
> > http://build.chromium.org/p/tryserver.chromium/builders/
> > linux_chromium_chromeos_clang_dbg/builds/4438/steps/compile%
> > 2520%2528with%2520patch%2529/logs/stdio
> >
> >> (search for gold64)
> >>
> >
> > Do you think you can easily fix that? Otherwise, can we revert?
> >
> > I'd like to land a change to make linker errors a tree closer on all
> > platforms
> >
> > https://codereview.chromium.org/189713002/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.