Rewrite platform headers in public/web/ to public/platform/...

Rewrite platform headers in public/web/ to public/platform/...

Includes of this style are more consistent with the rest of the project and
easier to verify with DEPS. For consistency, includes in public/web/ of other
headers in public/web/ are rewritten to list the public/web/ portion as well.

BUG=350097
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169597

[jamesr, 2014-03-07 01:22:56]

This has to land after https://codereview.chromium.org/189393003/ and
https://codereview.chromium.org/189713002/

[abarth-chromium, 2014-03-07 01:30:00]

lgtm

[jamesr, 2014-03-18 20:39:32]

Currently waiting for https://codereview.chromium.org/202143007/ (in the CQ),
then will try again.

[jamesr, 2014-03-19 22:58:37]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-03-19 22:58:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamesr@chromium.org/189703002/60001

[commit-bot: I haz the power, 2014-03-20 00:26:07]

Change committed as 169597

[tkent, 2014-03-20 03:38:06]

On 2014/03/20 00:26:07, I haz the power (commit-bot) wrote:
> Change committed as 169597

* Windows
http://chromegw.corp.google.com/i/chromium.webkit/builders/Win%20Builder/buil...
[282/1212] LIB obj\chrome\browser_real_2.lib
FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma\gomacc.exe
"C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo
/showIncludes /FC @obj\chrome\app\chrome_child_dll.chrome_main_delegate.obj.rsp
/c ..\..\chrome\app\chrome_main_delegate.cc
/Foobj\chrome\app\chrome_child_dll.chrome_main_delegate.obj
/Fdobj\chrome\chrome_child_dll.cc.pdb 
c:\b\build\slave\win-latest-rel\build\src\third_party\webkit\public\web\webnotificationpresenter.h(34)
: fatalerror C1083: Cannot open include file: 'public/platform/WebString.h': No
such file or directory
ninja: build stopped: subcommand failed.

* Mac
http://chromegw.corp.google.com/i/chromium.webkit/builders/Mac10.8%20Tests/bu...
[67/3902] CXX
obj/third_party/WebKit/Source/web/blink_web.GeolocationClientProxy.o
FAILED: clang++ -MMD -MF
obj/apps/app_shim/app_shim.extension_app_shim_handler_mac.o.d
-DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -DCHROMIUM_BUILD
-DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1
-DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY
-DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1
-DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY
-DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DENABLE_EGLIMAGE=1
-DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1
-DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1
-DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1
-DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_FULL_PRINTING=1
-DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1
-DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1
-DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1
'-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"'
-DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1
-DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_LEGACY_LAYERRASTERIZER_API=1
-DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT
-DSK_SUPPORT_LEGACY_COMPATIBLEDEVICE_CONFIG=1
-DSK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS=1
-DSK_SUPPORT_LEGACY_READPIXELSCONFIG -DSK_SUPPORT_LEGACY_GETCLIPTYPE
-DSK_SUPPORT_LEGACY_GETTOTALCLIP -DSK_SUPPORT_LEGACY_GETTOPDEVICE
-DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND
-DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Iobj/chrome/app_shim.gen
-Igen/chrome -I../.. -I../../skia/config -I../../third_party/skia/src/core
-I../../third_party/skia/include/core -I../../third_party/skia/include/effects
-I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu
-I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops
-I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports
-I../../third_party/skia/include/utils
-I../../third_party/skia/include/utils/mac -I../../skia/ext -isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk
-O3 -fvisibility=hidden -Werror -Wnewline-eof -mmacosx-version-min=10.6 -arch
i386 -Wall -Wendif-labels -Wextra -Wno-unused-parameter
-Wno-missing-field-initializers -Wheader-hygiene -Wno-c++11-narrowing
-Wno-char-subscripts -Wno-unneeded-internal-declaration
-Wno-covered-switch-default -Wstring-conversion -Wno-deprecated-register
-std=gnu++11 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden
-fno-threadsafe-statics -Xclang -load -Xclang
/Volumes/data/b/build/slave/Mac10_8_Tests/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
-Xclang -add-plugin -Xclang find-bad-constructs -Xclang
-plugin-arg-find-bad-constructs -Xclang check-url-directory -fcolor-diagnostics
-fno-strict-aliasing  -c ../../apps/app_shim/extension_app_shim_handler_mac.cc
-o obj/apps/app_shim/app_shim.extension_app_shim_handler_mac.o
In file included from ../../apps/app_shim/extension_app_shim_handler_mac.cc:19:
In file included from ../../chrome/browser/profiles/profile.h:16:
In file included from ../../content/public/browser/content_browser_client.h:25:
../../third_party/WebKit/public/web/WebNotificationPresenter.h:34:10:
fatalerror: 'public/platform/WebString.h' file not found
#include "public/platform/WebString.h"
         ^
1 error generated.

* ChromeOS
http://chromegw.corp.google.com/i/chromium.webkit/builders/Linux%20ChromiumOS...
288/1213] AR obj/content/libcontent_browser.a
FAILED: c++ -MMD -MF
obj/ash/shell/content_client/ash_shell.shell_content_browser_client.o.d
-DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME
-D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DTOOLKIT_VIEWS=1
-DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_CAIRO=1
-DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_X11=1 -DOS_CHROMEOS=1
-DUSE_XI2_MT=2 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1
-DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH
-DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DUSE_UDEV -DENABLE_EGLIMAGE=1
-DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1
-DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1
-DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 -DENABLE_GOOGLE_NOW=1
-DCLD_VERSION=2 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1
-DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1
-DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DGL_GLEXT_PROTOTYPES
-DLIBPEERCONNECTION_LIB=1 -DGTEST_HAS_POSIX_RE=0 -DSK_ENABLE_INST_COUNT=0
-DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"'
-DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1
-DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_LEGACY_LAYERRASTERIZER_API=1
-DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT
-DSK_SUPPORT_LEGACY_COMPATIBLEDEVICE_CONFIG=1
-DSK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS=1
-DSK_SUPPORT_LEGACY_READPIXELSCONFIG -DSK_SUPPORT_LEGACY_GETCLIPTYPE
-DSK_SUPPORT_LEGACY_GETTOTALCLIP -DSK_SUPPORT_LEGACY_GETTOPDEVICE
-DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1
-DU_USING_ICU_NAMESPACE=0 -DU_STATIC_IMPLEMENTATION -DUSE_NSS=1
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND
-DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -I../.. -I../../skia/config
-I../../third_party/khronos -I../../gpu -I../../third_party/WebKit/Source
-Igen/ash_strings -I../../third_party/skia/src/core
-I../../third_party/skia/include/core -I../../third_party/skia/include/effects
-I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu
-I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops
-I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports
-I../../third_party/skia/include/utils -I../../skia/ext
-I../../third_party/icu/source/i18n -I../../third_party/icu/source/common
-Igen/ui/ui_resources -Igen -Igen/ash/ash_resources -Werror -pthread
-fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter
-Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -pthread
-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -m64
-march=x86-64 -O2 -fno-ident -fdata-sections -ffunction-sections -funwind-tables
-fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare  -c
../../ash/shell/content_client/shell_content_browser_client.cc -o
obj/ash/shell/content_client/ash_shell.shell_content_browser_client.o
In file included from
../../content/public/browser/content_browser_client.h:25:0,
                 from
../../ash/shell/content_client/shell_content_browser_client.h:11,
                 from
../../ash/shell/content_client/shell_content_browser_client.cc:5:
../../third_party/WebKit/public/web/WebNotificationPresenter.h:34:39:
fatalerror: public/platform/WebString.h: No such file or directory
compilation terminated.

[tkent, 2014-03-20 03:39:20]

A revert of this CL has been created in
https://codereview.chromium.org/205153006/ by tkent@chromium.org.

The reason for reverting is: Broke Windows, Mac, and ChromeOS build.
.

[jamesr, 2014-03-20 03:40:37]

Doh, guess those tryjobs were not enough. The fixes will be easy (add
blink_headers dependencies or exports as needed) but feel free to revert if
you would like. With the logs I can fix these problems and land again when
I am able to watch for fallout.

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.