content/renderer/render_view_impl.cc - Issue 1896953002: Fix cross-site popups to inherit their opener's sandbox flags even when popup opener is not set.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 1896953002: Fix cross-site popups to inherit their opener's sandbox flags even when popup opener is not set. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_frame_host_manager_browsertest.cc ('k') | content/test/data/click-noreferrer-links.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index ae2d8ec04452d126ac74ef61e8b699f7ad5341c7..4da799e6cf1d1993c5aca98dd6c04b625d0d7f46 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -794,8 +794,7 @@ void RenderViewImpl::Initialize(const ViewMsg_New_Params& params,

// Ensure that sandbox flags are inherited from an opener in a different

// process. In that case, the browser process will set any inherited sandbox

// flags in |replicated_frame_state|, so apply them here.

- if (opener_frame && !was_created_by_renderer &&

- webview()->mainFrame()->isWebLocalFrame()) {

+ if (!was_created_by_renderer && webview()->mainFrame()->isWebLocalFrame()) {

webview()->mainFrame()->toWebLocalFrame()->forceSandboxFlags(

params.replicated_frame_state.sandbox_flags);

}