DescriptionRemove PrerenderManager::OnCloseWebContentsDeleter::SwappedOut
Formerly this event was needed to eliminate old WebContents leak on swap
(crbug.com/103966). Recently with heroic refactoring the
WebContentsDelegate::SwappedOut() stopped being delivered.
This makes it safe to remove OnCloseWebContentsDeleter::SwappedOut().
The old WebContents does not leak because the way it is replaced is:
1. Subscribe to CloseContents() with our WebContentsDelegate
2. old_web_contents->DispatchBeforeUnload()
3. After 3 seconds, destroy the old_web_contents regardless of beforeunload
dispatching
4. In CloseContents() we also destroy old_web_contents, but maybe sooner
.. modulo some deduplication of destroying and other cleanup happening around
asynchronously.
BUG=600693
Committed: https://crrev.com/9299995e124ff8fe4542790b1a9f1aed6252ec1c
Cr-Commit-Position: refs/heads/master@{#390327}
Patch Set 1 #Patch Set 2 : Enhanced PrerenderUnload test with WebContents destruction check #Patch Set 3 : make it compile #
Messages
Total messages: 16 (6 generated)
|