Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1896943002: Remove PrerenderManager::OnCloseWebContentsDeleter::SwappedOut (Closed)

Created:
4 years, 8 months ago by pasko
Modified:
4 years, 7 months ago
Reviewers:
mmenke
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, davidben+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PrerenderManager::OnCloseWebContentsDeleter::SwappedOut Formerly this event was needed to eliminate old WebContents leak on swap (crbug.com/103966). Recently with heroic refactoring the WebContentsDelegate::SwappedOut() stopped being delivered. This makes it safe to remove OnCloseWebContentsDeleter::SwappedOut(). The old WebContents does not leak because the way it is replaced is: 1. Subscribe to CloseContents() with our WebContentsDelegate 2. old_web_contents->DispatchBeforeUnload() 3. After 3 seconds, destroy the old_web_contents regardless of beforeunload dispatching 4. In CloseContents() we also destroy old_web_contents, but maybe sooner .. modulo some deduplication of destroying and other cleanup happening around asynchronously. BUG=600693 Committed: https://crrev.com/9299995e124ff8fe4542790b1a9f1aed6252ec1c Cr-Commit-Position: refs/heads/master@{#390327}

Patch Set 1 #

Patch Set 2 : Enhanced PrerenderUnload test with WebContents destruction check #

Patch Set 3 : make it compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -6 lines) Patch
M chrome/browser/prerender/prerender_browsertest.cc View 1 2 3 chunks +26 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_manager.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
pasko
As discussed in the bug, the reason why SwappedOut() was introduced is because old WebContents ...
4 years, 7 months ago (2016-04-25 18:26:55 UTC) #4
pasko
On 2016/04/25 18:26:55, pasko wrote: > As discussed in the bug, the reason why SwappedOut() ...
4 years, 7 months ago (2016-04-26 08:10:22 UTC) #5
mmenke
On 2016/04/26 08:10:22, pasko wrote: > On 2016/04/25 18:26:55, pasko wrote: > > As discussed ...
4 years, 7 months ago (2016-04-26 15:32:58 UTC) #7
pasko
On 2016/04/26 15:32:58, mmenke wrote: > On 2016/04/26 08:10:22, pasko wrote: > > On 2016/04/25 ...
4 years, 7 months ago (2016-04-26 15:40:24 UTC) #8
mmenke
On 2016/04/26 15:40:24, pasko wrote: > On 2016/04/26 15:32:58, mmenke wrote: > > On 2016/04/26 ...
4 years, 7 months ago (2016-04-27 02:56:56 UTC) #9
pasko
On 2016/04/27 02:56:56, mmenke wrote: > I'd suggest adding the WebContents deletion check to the ...
4 years, 7 months ago (2016-04-27 18:08:49 UTC) #10
mmenke
On 2016/04/27 18:08:49, pasko wrote: > On 2016/04/27 02:56:56, mmenke wrote: > > I'd suggest ...
4 years, 7 months ago (2016-04-27 18:10:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896943002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896943002/40001
4 years, 7 months ago (2016-04-28 07:37:28 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-04-28 08:16:41 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:16:59 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9299995e124ff8fe4542790b1a9f1aed6252ec1c
Cr-Commit-Position: refs/heads/master@{#390327}

Powered by Google App Engine
This is Rietveld 408576698