PPC: First version of the new generators implementation.

PPC: First version of the new generators implementation.

Port d0ccddd0324aa9391e76b611481bdc47f0f073de

Original commit message:
       First version of the new generators implementation.

       Behind --ignition-generators. Does not yet support Turbofan.

R=neis@chromium.org, joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com, jyan@ca.ibm.com
BUG=v8:4907
LOG=N

Committed: https://crrev.com/9ff4a69147a7e8ac2ce4d17ea57970806784cc05
Cr-Commit-Position: refs/heads/master@{#35600}

[JaideepBajwa, 2016-04-18 17:42:46]

PTAL

[MTBrandyberry, 2016-04-18 18:08:55]

https://codereview.chromium.org/1896933002/diff/1/src/ppc/builtins-ppc.cc
File src/ppc/builtins-ppc.cc (right):

https://codereview.chromium.org/1896933002/diff/1/src/ppc/builtins-ppc.cc#new...
src/ppc/builtins-ppc.cc:794: __ LoadP(r3,
The formal parameter count is an integer value.  See above for proper load and
untag sequence.

Bonus points:  I'm not sure why we'd want to reload this value since we've done
it above and the loop doesn't trash the value as it does on ARM.  It seems like
we should just stash it in a register that survives until this section.

https://codereview.chromium.org/1896933002/diff/1/src/ppc/builtins-ppc.cc#new...
src/ppc/builtins-ppc.cc:803: __ Jump(r5);
When calling a javascript object entry, we need to call via the ip register for
proper constant pool addressibility.  Load into ip and use the JumpToJSEntry
macro.

[MTBrandyberry, 2016-04-18 20:55:10]

https://codereview.chromium.org/1896933002/diff/40001/src/ppc/builtins-ppc.cc
File src/ppc/builtins-ppc.cc (right):

https://codereview.chromium.org/1896933002/diff/40001/src/ppc/builtins-ppc.cc...
src/ppc/builtins-ppc.cc:764: __ LoadP(r3, FieldMemOperand(r7,
JSFunction::kSharedFunctionInfoOffset));
If you leave this load target as r6, you can omit the load on line 786.

[MTBrandyberry, 2016-04-18 21:07:56]

lgtm

[JaideepBajwa, 2016-04-18 21:08:32]

The CQ bit was checked by bjaideep@ca.ibm.com

[commit-bot: I haz the power, 2016-04-18 21:08:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1896933002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1896933002/80001

[commit-bot: I haz the power, 2016-04-18 22:48:15]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-18 22:50:21]

Description was changed from

==========
PPC: First version of the new generators implementation.

Port d0ccddd0324aa9391e76b611481bdc47f0f073de

Original commit message:
       First version of the new generators implementation.

       Behind --ignition-generators. Does not yet support Turbofan.

R=neis@chromium.org, joransiu@ca.ibm.com, mbrandy@us.ibm.com,
michael_dawson@ca.ibm.com, jyan@ca.ibm.com
BUG=v8:4907
LOG=N
==========

to

==========
PPC: First version of the new generators implementation.

Port d0ccddd0324aa9391e76b611481bdc47f0f073de

Original commit message:
       First version of the new generators implementation.

       Behind --ignition-generators. Does not yet support Turbofan.

R=neis@chromium.org, joransiu@ca.ibm.com, mbrandy@us.ibm.com,
michael_dawson@ca.ibm.com, jyan@ca.ibm.com
BUG=v8:4907
LOG=N

Committed: https://crrev.com/9ff4a69147a7e8ac2ce4d17ea57970806784cc05
Cr-Commit-Position: refs/heads/master@{#35600}
==========

[commit-bot: I haz the power, 2016-04-18 22:50:22]

Patchset 5 (id:??) landed as
https://crrev.com/9ff4a69147a7e8ac2ce4d17ea57970806784cc05
Cr-Commit-Position: refs/heads/master@{#35600}