Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issue 1896923002: Make FWL_CornerEnlarge a const (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make FWL_CornerEnlarge a const This CL changes the FWL_CornerEnlarge define into a const value in the anonymous namespace. Committed: https://pdfium.googlesource.com/pdfium/+/076f5ac6084e3170dabfc598541dd4e94126dc9c

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -18 lines) Patch
M xfa/fwl/core/fwl_formimp.cpp View 2 chunks +20 lines, -18 lines 2 comments Download

Messages

Total messages: 8 (3 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-04-18 17:38:57 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1896923002/diff/1/xfa/fwl/core/fwl_formimp.cpp File xfa/fwl/core/fwl_formimp.cpp (right): https://codereview.chromium.org/1896923002/diff/1/xfa/fwl/core/fwl_formimp.cpp#newcode31 xfa/fwl/core/fwl_formimp.cpp:31: const uint8_t kCornerEnlarge = 10; nit: we wouldn't ...
4 years, 8 months ago (2016-04-18 18:00:57 UTC) #3
dsinclair
https://codereview.chromium.org/1896923002/diff/1/xfa/fwl/core/fwl_formimp.cpp File xfa/fwl/core/fwl_formimp.cpp (right): https://codereview.chromium.org/1896923002/diff/1/xfa/fwl/core/fwl_formimp.cpp#newcode31 xfa/fwl/core/fwl_formimp.cpp:31: const uint8_t kCornerEnlarge = 10; On 2016/04/18 18:00:57, Tom ...
4 years, 8 months ago (2016-04-18 19:09:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896923002/1
4 years, 8 months ago (2016-04-18 19:09:43 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 19:10:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/076f5ac6084e3170dabfc598541dd4e94126...

Powered by Google App Engine
This is Rietveld 408576698