Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2006)

Unified Diff: net/BUILD.gn

Issue 1896903002: [GN/iOS] Explicitly list test data in net_unittests_bundle_data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-fix-tests-ui-gfx
Patch Set: Define the file list in net/net.gypi and sync gyp & gn Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/security_state/BUILD.gn ('k') | net/net.gyp » ('j') | net/net.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/BUILD.gn
diff --git a/net/BUILD.gn b/net/BUILD.gn
index 0e2823980b23256535a14fbc8588c173fa434f07..4f64b9962d7f0b6e506bdf92c6ba668e0c5a06bc 100644
--- a/net/BUILD.gn
+++ b/net/BUILD.gn
@@ -587,10 +587,9 @@ if (!is_ios) {
}
bundle_data("test_support_bundle_data") {
+ visibility = [ ":test_support" ]
testonly = true
- sources = [
- "data/ssl/certificates",
- ]
+ sources = gypi_values.net_test_support_data_sources
outputs = [
"{{bundle_resources_dir}}/" +
"{{source_root_relative_dir}}/{{source_file_part}}",
@@ -702,10 +701,6 @@ source_set("test_support") {
"//build/config/compiler:no_size_t_to_int_warning",
]
- deps = [
- ":test_support_bundle_data",
- ]
-
public_deps = [
"//base",
"//base/test:test_support",
@@ -717,6 +712,10 @@ source_set("test_support") {
"//url",
]
+ deps = [
+ ":test_support_bundle_data",
+ ]
+
if (!is_ios) {
public_deps += [ "//third_party/protobuf:py_proto" ]
}
@@ -1407,18 +1406,7 @@ if (!is_ios) {
bundle_data("net_unittests_bundle_data") {
testonly = true
- sources = [
- "data/certificate_policies_unittest",
- "data/name_constraints_unittest",
- "data/parse_certificate_unittest",
- "data/parse_ocsp_unittest",
- "data/test.html",
- "data/url_request_unittest",
- "data/verify_certificate_chain_unittest",
- "data/verify_name_match_unittest/names",
- "third_party/nist-pkits/certs",
- "third_party/nist-pkits/crls",
- ]
+ sources = gypi_values.net_unittests_data_sources
outputs = [
"{{bundle_resources_dir}}/" +
"{{source_root_relative_dir}}/{{source_file_part}}",
« no previous file with comments | « components/security_state/BUILD.gn ('k') | net/net.gyp » ('j') | net/net.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698