Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 1896893004: Hook up style invalidation for CSS Paint API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@css-paint-register
Patch Set: rebase. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index 504259b74d5d9eafac10c6fcd1c2229d6e78cba2..71680c8b474ccc730920eb61a4b7ccda1d086fc0 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -22,6 +22,8 @@
#include "core/style/ComputedStyle.h"
+#include "core/css/CSSPaintValue.h"
+#include "core/css/CSSPropertyEquality.h"
#include "core/css/resolver/StyleResolver.h"
#include "core/layout/LayoutTheme.h"
#include "core/layout/TextAutosizer.h"
@@ -45,6 +47,7 @@
#include "platform/transforms/ScaleTransformOperation.h"
#include "platform/transforms/TranslateTransformOperation.h"
#include "wtf/MathExtras.h"
+#include "wtf/PtrUtil.h"
#include <algorithm>
@@ -762,6 +765,43 @@ bool ComputedStyle::diffNeedsPaintInvalidationObject(const ComputedStyle& other)
if (resize() != other.resize())
return true;
+ if (rareNonInheritedData->m_paintImages) {
+ for (const auto& image : *rareNonInheritedData->m_paintImages) {
+ if (diffNeedsPaintInvalidationObjectForPaintImage(image, other))
+ return true;
+ }
+ }
+
+ return false;
+}
+
+bool ComputedStyle::diffNeedsPaintInvalidationObjectForPaintImage(const StyleImage* image, const ComputedStyle& other) const
+{
+ CSSPaintValue* value = toCSSPaintValue(image->cssValue());
+
+ // NOTE: If the invalidation properties vectors are null, we are invalid as
+ // we haven't yet been painted (and can't provide the invalidation
+ // properties yet).
+ if (!value->nativeInvalidationProperties() || !value->customInvalidationProperties())
+ return true;
+
+ for (CSSPropertyID propertyID : *value->nativeInvalidationProperties()) {
+ // TODO(ikilpatrick): remove isInterpolableProperty check once
+ // CSSPropertyEquality::propertiesEqual correctly handles all properties.
+ if (!CSSPropertyMetadata::isInterpolableProperty(propertyID) || !CSSPropertyEquality::propertiesEqual(propertyID, *this, other))
+ return true;
+ }
+
+ if (variables() || other.variables()) {
+ for (const AtomicString& property : *value->customInvalidationProperties()) {
+ CSSVariableData* thisVar = variables() ? variables()->getVariable(property) : nullptr;
+ CSSVariableData* otherVar = other.variables() ? other.variables()->getVariable(property) : nullptr;
+
+ if (!dataEquivalent(thisVar, otherVar))
+ return true;
+ }
+ }
+
return false;
}
@@ -819,6 +859,13 @@ void ComputedStyle::updatePropertySpecificDifferences(const ComputedStyle& other
}
}
+void ComputedStyle::addPaintImage(StyleImage* image)
+{
+ if (!rareNonInheritedData.access()->m_paintImages)
+ rareNonInheritedData.access()->m_paintImages = WTF::wrapUnique(new Vector<Persistent<StyleImage>>());
+ rareNonInheritedData.access()->m_paintImages->append(image);
+}
+
void ComputedStyle::addCursor(StyleImage* image, bool hotSpotSpecified, const IntPoint& hotSpot)
{
if (!rareInheritedData.access()->cursorData)
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.h ('k') | third_party/WebKit/Source/core/style/StyleGeneratedImage.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698