third_party/WebKit/Source/modules/csspaint/README.md - Issue 1896893004: Hook up style invalidation for CSS Paint API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/csspaint/README.md

Issue 1896893004: Hook up style invalidation for CSS Paint API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@css-paint-register

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/style/StyleRareNonInheritedData.h ('K') | « third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/csspaint/README.md

diff --git a/third_party/WebKit/Source/modules/csspaint/README.md b/third_party/WebKit/Source/modules/csspaint/README.md

index 926274472e6b4981aadbef3fbbcebc131f799f92..860623bbe5e8c18aa3aaef7e77be6eb1658951b1 100644

--- a/third_party/WebKit/Source/modules/csspaint/README.md

+++ b/third_party/WebKit/Source/modules/csspaint/README.md

@@ -49,6 +49,15 @@ This method returns the `PaintGeneratedImage`.

The `SkPicture` is produced from a `RecordingImageBufferSurface`.

+### Style Invalidation

+The `CSSPaintDefinition` keeps a list of both native and custom properties it will invalidate on.

+During style invalidation `ComputedStyle` checks if it has any `CSSPaintValue`s, and if any of their

+properties have changed; if so it will invalidate paint for that `ComputedStyle`.

+If the `CSSPaintValue` doesn't have a corresponding `CSSPaintDefinition` yet, it doesn't invalidate

+paint.

## Testing

Tests live [here](../../../LayoutTests/csspaint/).