Hook up style invalidation for CSS Paint API.

third_party/WebKit/Source/core/style/ComputedStyle.cpp

 /*
  * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  *
  */
 
 #include "core/style/ComputedStyle.h"
 
+#include "core/css/CSSPaintValue.h"
+#include "core/css/CSSPropertyEquality.h"
 #include "core/css/resolver/StyleResolver.h"
 #include "core/layout/LayoutTheme.h"
 #include "core/layout/TextAutosizer.h"
 #include "core/style/AppliedTextDecoration.h"
 #include "core/style/BorderEdge.h"
 #include "core/style/ContentData.h"
 #include "core/style/DataEquivalency.h"
 #include "core/style/ComputedStyleConstants.h"
 #include "core/style/QuotesData.h"
 #include "core/style/ShadowList.h"
@@ skipping 717 matching lines @@
             || (visitedLinkBorderBottomColor() != other.visitedLinkBorderBottomColor() && borderBottomWidth())
             || (visitedLinkBorderTopColor() != other.visitedLinkBorderTopColor() && borderTopWidth())
             || (visitedLinkOutlineColor() != other.visitedLinkOutlineColor() && outlineWidth())
             || (visitedLinkBackgroundColor() != other.visitedLinkBackgroundColor()))
             return true;
     }
 
     if (resize() != other.resize())
         return true;
 
+    for (const auto& image : paintImages()) {
+        if (diffNeedsPaintInvalidationObjectForPaintImage(image, other))
+            return true;
+    }
+
     return false;
 }
 
+bool ComputedStyle::diffNeedsPaintInvalidationObjectForPaintImage(const StyleImage* image, const ComputedStyle& other) const
+{
+    CSSPaintValue* value = toCSSPaintValue(image->cssValue());
+
+    if (!value->nativeInvalidationProperties() || !value->customInvalidationProperties())
+        return true;
+
+    for (CSSPropertyID propertyID : *value->nativeInvalidationProperties()) {
+        if (!CSSPropertyEquality::propertiesEqual(propertyID, *this, other))
+            return true;
+    }
+
+    for (const AtomicString& property : *value->customInvalidationProperties()) {
+        CSSVariableData* thisVar = variables() ? variables()->getVariable(property) : nullptr;
+        CSSVariableData* otherVar = other.variables() ? other.variables()->getVariable(property) : nullptr;
+
+        if (thisVar == otherVar)
+            continue;
+
+        if (!thisVar || !otherVar)
+            return true;
+
+        if (thisVar->tokenRange().serialize() != otherVar->tokenRange().serialize())

[rune, 2016/04/29 08:06:37]

Could you implement an operator==() on CSSTokenRange instead? If whitespace
tokens are preserved (and they're never significant in declarations?), make a
comparison method that skips whitespaces?

[ikilpatrick, 2016/04/29 22:42:01]

+timloh to see what he thinks.

Tim what do you think of operator==() on CSSTokenRange?

I also just checked ant operator==() on CSSParserToken doesn't seemed to be used
anywhere? So could also change to to do a deep equality check instead of just
the pointer comparison it does at the moment. Tim thoughts?

[Timothy Loh, 2016/05/03 08:01:39]

It should be used to in style diffing at the moment to avoid subtree recalcs.

StyleRareInheritedData::operator==
StyleVariableData::operator==
CSSVariableData::operator==

+            return true;
+    }
+
+    return false;
+}
+
 void ComputedStyle::updatePropertySpecificDifferences(const ComputedStyle& other, StyleDifference& diff) const
 {
     // StyleAdjuster has ensured that zIndex is non-auto only if it's applicable.
     if (m_box->zIndex() != other.m_box->zIndex() || m_box->hasAutoZIndex() != other.m_box->hasAutoZIndex())
         diff.setZIndexChanged();
 
     if (rareNonInheritedData.get() != other.rareNonInheritedData.get()) {
         if (!transformDataEquivalent(other))
             diff.setTransformChanged();
 
@@ skipping 1028 matching lines @@
     if (!shadowList)
         return false;
     for (size_t i = shadowList->shadows().size(); i--; ) {
         if (shadowList->shadows()[i].color().isCurrentColor())
             return true;
     }
     return false;
 }
 
 } // namespace blink