third_party/WebKit/LayoutTests/csspaint/invalidation-background-image.html - Issue 1896893004: Hook up style invalidation for CSS Paint API.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/csspaint/invalidation-background-image.html

Issue 1896893004: Hook up style invalidation for CSS Paint API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@css-paint-register

Patch Set: . Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/csspaint/invalidation-background-image-expected.txt » ('j') | third_party/WebKit/Source/modules/csspaint/PaintWorkletGlobalScope.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../resources/run-after-layout-and-paint.js"></script>

	5 <script src="resources/test-runner-invalidation-logging.js"></script>

	6 <style>

	7 div {

	8 width: 100px;

	9 height: 100px;

	10 background-color: red;

	11 }

	12 </style>

	13 </head>

	14 <body>

	15 <p>This tests the invalidation behaviour of the paint callback.</p>

	16 <p>See the devtools console for test output.</p>

	17 <script>

	18 // TODO(ikilpatrick): Should test shorthands and direction aware properties.

	19 testRunnerInvalidationLogging('background-image', [

	20 { property: 'max-height', value: '160px' },
	chrishtr 2016/04/27 19:52:40 It doesn't look like these tests check the new val It doesn't look like these tests check the new value of the property? ikilpatrick 2016/04/28 22:30:16 Need the TypedOM to plumb through the values of th Show quoted text On 2016/04/27 19:52:40, chrishtr wrote: > It doesn't look like these tests check the new value of the property? Need the TypedOM to plumb through the values of the new property. Will modify these / create new once we have that. chrishtr 2016/04/29 00:25:33 Ok please file a bug to remind yourself to do it? Show quoted text On 2016/04/28 at 22:30:16, ikilpatrick wrote: > On 2016/04/27 19:52:40, chrishtr wrote: > > It doesn't look like these tests check the new value of the property? > > Need the TypedOM to plumb through the values of the new property. Will modify these / create new once we have that. Ok please file a bug to remind yourself to do it? ikilpatrick 2016/04/29 22:42:01 Done: https://bugs.chromium.org/p/chromium/issues/ Show quoted text On 2016/04/29 00:25:33, chrishtr wrote: > On 2016/04/28 at 22:30:16, ikilpatrick wrote: > > On 2016/04/27 19:52:40, chrishtr wrote: > > > It doesn't look like these tests check the new value of the property? > > > > Need the TypedOM to plumb through the values of the new property. Will modify > these / create new once we have that. > > Ok please file a bug to remind yourself to do it? Done: https://bugs.chromium.org/p/chromium/issues/detail?id=608082
	21 { property: 'border-top-color', value: 'blue' },

	22 { property: 'flex-basis', value: '100px' },

	23 { property: 'flex-grow', value: '2' },

	24 { property: 'color', value: 'red' },

	25 { property: '--foo', value: 'foo' },

	26 ]);

	27 </script>

	28 </body>

	29 </html>

OLD	NEW