Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1896883003: Revert of 🏄 [heap] Add page evacuation mode for new->old (Closed)

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of 🏄 [heap] Add page evacuation mode for new->old (patchset #21 id:800001 of https://codereview.chromium.org/1863983002/ ) Reason for revert: [Sheriff] Breaks: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug/builds/102 Original issue's description: > [heap] Add page evacuation mode for new->old > > In a full mark-compact GC, instead of copying memory to old space for > pages that have more than X% live bytes, we just move the whole page over to old > space. > > X=70 (default value) > > BUG=chromium:581412 > LOG=N > > Committed: https://crrev.com/0d7e23a6edd3822970983030a77a5b80cd337911 > Cr-Commit-Position: refs/heads/master@{#35610} TBR=hpayer@chromium.org,ulan@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:581412 Committed: https://crrev.com/8b3337278f4202b058b37dcae35f66a7eef8f5c5 Cr-Commit-Position: refs/heads/master@{#35619}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -252 lines) Patch
M src/flag-definitions.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/heap/mark-compact.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/heap/mark-compact.cc View 15 chunks +47 lines, -121 lines 0 comments Download
M src/heap/spaces.h View 8 chunks +5 lines, -24 lines 0 comments Download
M src/heap/spaces.cc View 2 chunks +1 line, -14 lines 0 comments Download
M src/heap/spaces-inl.h View 2 chunks +1 line, -16 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 2 chunks +0 lines, -48 lines 0 comments Download
M test/cctest/heap/utils-inl.h View 1 chunk +12 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of 🏄 [heap] Add page evacuation mode for new->old
4 years, 8 months ago (2016-04-19 12:51:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896883003/1
4 years, 8 months ago (2016-04-19 12:51:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 12:51:43 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 12:52:53 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b3337278f4202b058b37dcae35f66a7eef8f5c5
Cr-Commit-Position: refs/heads/master@{#35619}

Powered by Google App Engine
This is Rietveld 408576698