Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: content/renderer/media/audio_message_filter_unittest.cc

Issue 1896883002: Mojo interfaces needed for switching audio rendering stream creation and closing from IPC to Mojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/audio_message_filter_unittest.cc
diff --git a/content/renderer/media/audio_message_filter_unittest.cc b/content/renderer/media/audio_message_filter_unittest.cc
index e94e8cba55819f65e36f5c9e543d5dae0a8d29e9..db34ffbcd04a8738bb5858461cda1bac19513db5 100644
--- a/content/renderer/media/audio_message_filter_unittest.cc
+++ b/content/renderer/media/audio_message_filter_unittest.cc
@@ -9,6 +9,7 @@
#include "base/macros.h"
#include "content/common/media/audio_messages.h"
#include "content/renderer/media/audio_message_filter.h"
+#include "content/renderer/media/audio_output_client.h"
#include "media/audio/audio_output_ipc.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -108,6 +109,8 @@ TEST(AudioMessageFilterTest, Basic) {
scoped_refptr<AudioMessageFilter> filter(
new AudioMessageFilter(message_loop.task_runner()));
+ filter->audio_output_client_.reset(new AudioOutputClient(
+ NULL, filter));
MockAudioDelegate delegate;
const std::unique_ptr<media::AudioOutputIPC> ipc =
@@ -134,8 +137,8 @@ TEST(AudioMessageFilterTest, Basic) {
base::SyncSocket::TransitDescriptor socket_descriptor;
const uint32_t kLength = 1024;
EXPECT_FALSE(delegate.created_received());
- filter->OnMessageReceived(AudioMsg_NotifyStreamCreated(
- kStreamId, base::SharedMemory::NULLHandle(), socket_descriptor, kLength));
+ filter->OnStreamCreated(
+ kStreamId, base::SharedMemory::NULLHandle(), socket_descriptor, kLength);
EXPECT_TRUE(delegate.created_received());
EXPECT_FALSE(base::SharedMemory::IsHandleValid(delegate.handle()));
EXPECT_EQ(kLength, delegate.length());
@@ -161,6 +164,8 @@ TEST(AudioMessageFilterTest, Delegates) {
scoped_refptr<AudioMessageFilter> filter(
new AudioMessageFilter(message_loop.task_runner()));
+ filter->audio_output_client_.reset(new AudioOutputClient(
+ NULL, filter));
MockAudioDelegate delegate1;
MockAudioDelegate delegate2;
const std::unique_ptr<media::AudioOutputIPC> ipc1 =
@@ -171,9 +176,9 @@ TEST(AudioMessageFilterTest, Delegates) {
ipc2->CreateStream(&delegate2, media::AudioParameters());
static const int kStreamId1 = 1;
static const int kStreamId2 = 2;
+
EXPECT_EQ(&delegate1, filter->delegates_.Lookup(kStreamId1));
EXPECT_EQ(&delegate2, filter->delegates_.Lookup(kStreamId2));
-
// Send an IPC message. Make sure the correct delegate gets called.
EXPECT_FALSE(delegate1.state_changed_received());
EXPECT_FALSE(delegate2.state_changed_received());

Powered by Google App Engine
This is Rietveld 408576698