Mojo interfaces needed for switching audio rendering stream creation and closing from IPC to Mojo

media/mojo/interfaces/media_types.mojom

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 module media.interfaces;
 
 import "ui/mojo/geometry/geometry.mojom";
 
+// See media/audio/audio_parameters.h for descriptions.
+// Kept in sync with media::AudioParameters::Format via static_asserts.
+enum AudioFormat {
+  AUDIO_PCM_LINEAR = 0,
+  AUDIO_PCM_LOW_LATENCY,
+  AUDIO_FAKE,
+  AUDIO_FORMAT_LAST = AUDIO_FAKE,
+};
+
 // See media/base/buffering_state.h for descriptions.
 // Kept in sync with media::BufferingState via static_asserts.
 enum BufferingState {
   HAVE_NOTHING,
   HAVE_ENOUGH,
 };
 
 // See media/base/audio_decoder_config.h for descriptions.
 // Kept in sync with media::AudioCodec via static_asserts.
 enum AudioCodec {
@@ skipping 154 matching lines @@
 
 // See media/base/encryption_scheme.h.
 // Kept in sync with media::CipherMode via static_asserts.
 enum CipherMode {
   UNENCRYPTED = 0,
   AES_CTR,
   AES_CBC,
   MAX = AES_CBC
 };
 
+// This defines a mojo transport format for media::AudioParameters without
+// the |mic_positions_| vector. This will be used by 
+// media.interfaces.AudioOutput. CreateStream which doesn't need the vector.
+// See media/base/media/base/audio_parameters.h for description.

[xhwang, 2016/04/29 17:47:57]

Drop extra media/base/

[rchtara, 2016/05/02 15:54:11]

Done.

+struct AudioOutputStreamParameters {

[xhwang, 2016/04/29 17:47:57]

It seems to me a different name actually caused more confusion :)

How about we keep the AudioParameters name, add a TODO after line 204 to add
|mic_positions_| if needed. Then in the type converters CHECK/DCHECK that the
|mic_positions_| must be empty?

[rchtara, 2016/05/02 15:54:11]

Done.

+  AudioFormat format;                   // Format of the stream.
+  ChannelLayout channel_layout;    // Order of surround sound channels.
+  int32 channels;                  // Number of channels. Value set based on
+                                    // |channel_layout|.
+  int32 sample_rate;               // Sampling frequency/rate.
+  int32 bits_per_sample;           // Number of bits per sample.
+  int32 frames_per_buffer;         // Number of frames in a buffer.
+  int32 effects;                   // Bitmask using PlatformEffectsMask.

[mcasas, 2016/04/29 17:14:11]

You shouldn't align these comments, instead,
leave two blanks after the ; and start the //

[rchtara, 2016/05/02 15:54:11]

grunnel told me that:
Actually, I think it's better to remove the comments from here, to avoid
redundancy. Above it says "See media/base/media/base/audio_parameters.h for
description", which should be enough. In the rest of the file there is only
comments in one struct (I think), the other have no comments.
So, i removed them.

+};
+
 // This defines a mojo transport format for media::EncryptionScheme::Pattern
 // See media/base/encryption_scheme.h for description.
 struct Pattern {
   uint32 encrypt_blocks;
   uint32 skip_blocks;
 };
 
 // This defines a mojo transport format for media::EncryptionScheme.
 // See media/base/encryption_scheme.h for description.
 struct EncryptionScheme {
@@ skipping 124 matching lines @@
 
   // Stride and offsets for each plane. Offsets are relative to the start
   // of |frame_data|.
   int32 y_stride;
   int32 u_stride;
   int32 v_stride;
   uint64 y_offset;
   uint64 u_offset;
   uint64 v_offset;
 };