media/mojo/interfaces/audio_output.mojom - Issue 1896883002: Mojo interfaces needed for switching audio rendering stream creation and closing from IPC to Mojo

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/mojo/interfaces/audio_output.mojom

Issue 1896883002: Mojo interfaces needed for switching audio rendering stream creation and closing from IPC to Mojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: All grunell comments resolved Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module content.mojom;
	xhwang 2016/04/26 22:54:42 This file is in media/mojo where we use media.inte This file is in media/mojo where we use media.interfaces as the module. We do have a plan to switch to media.mojom in the future, but for now it'd be nice to be consistent with existing interfaces. rchtara 2016/04/29 12:54:46 Done. Show quoted text On 2016/04/26 22:54:42, xhwang wrote: > This file is in media/mojo where we use media.interfaces as the module. We do > have a plan to switch to media.mojom in the future, but for now it'd be nice to > be consistent with existing interfaces. Done.
	6

	7 import "media/mojo/interfaces/media_types.mojom";

	8

	9 interface AudioOutputStream {
	xhwang 2016/04/26 22:54:42 Please provide some comments about what this is fo Please provide some comments about what this is for. An interface with just a Close() call seems odd. rchtara 2016/04/29 12:54:46 Done. Show quoted text On 2016/04/26 22:54:42, xhwang wrote: > Please provide some comments about what this is for. An interface with just a > Close() call seems odd. Done.
	10 Close();

	11 };

	12

	13 interface AudioOutput {
	xhwang 2016/04/26 22:54:42 ditto for comments. ditto for comments. rchtara 2016/04/29 12:54:46 Done. Show quoted text On 2016/04/26 22:54:42, xhwang wrote: > ditto for comments. Done.
	14 CreateStream(

	15 int32 stream_id,

	16 int32 render_frame_id,
	xhwang 2016/04/26 22:54:42 Hmm, media should know nothing about content (e.g. Hmm, media should know nothing about content (e.g. render_frame_id). If this is really necessary, then this interface should be defined in content instead in media. rchtara 2016/04/29 12:54:46 At the beginning, I tried to define the interface Show quoted text On 2016/04/26 22:54:42, xhwang wrote: > Hmm, media should know nothing about content (e.g. render_frame_id). If this is > really necessary, then this interface should be defined in content instead in > media. At the beginning, I tried to define the interface in content, but I failed and I got a presubmit error: as the interface is going to be used in audio_output_controller.h which is in media and we cannot include things defined in content in media.
	17 media.interfaces.AudioOutputStreamParameters params) =>

	18 (int32 stream_id,

	19 AudioOutputStream? stream,

	20 handle<shared_buffer>? shared_buffer,

	21 handle? socket_descriptor);

	22 };

OLD	NEW

« media/audio/BUILD.gn ('K') | « media/mojo/interfaces/BUILD.gn ('k') | media/mojo/interfaces/media_types.mojom » ('j') | media/mojo/interfaces/media_types.mojom » ('J')