Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1896863003: [wasm] Binary 11: Module changes. (Closed)

Created:
4 years, 8 months ago by titzer
Modified:
4 years, 7 months ago
Reviewers:
ahaas, JF, rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Binary 11: Bump module version to 0xB. [wasm] Binary 11: Swap the order of section name / section length. [wasm] Binary 11: Shorter section names. [wasm] Binary 11: Add a prefix for function type declarations. [wasm] Binary 11: Function types encoded as pcount, p*, rcount, r* [wasm] Fix numeric names for functions. R=rossberg@chromium.org,jfb@chromium.org,ahaas@chromium.org BUG=chromium:575167 LOG=Y Committed: https://crrev.com/ee03b7217b040a0f51c41c59a6b861979eefac89 Cr-Commit-Position: refs/heads/master@{#35897}

Patch Set 1 #

Patch Set 2 : Merge in section name/length and add function type form byte. #

Patch Set 3 : Rebase on if/else block change #

Patch Set 4 : Rebase onto addition of arities. #

Patch Set 5 : Fix encoding of parameter and return types in signatures. #

Patch Set 6 : Rebase #

Patch Set 7 : bump version to 11 #

Patch Set 8 : Fix numeric names. #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : Rebase on Wasm.experimentalVersion #

Patch Set 12 : #

Patch Set 13 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+505 lines, -414 lines) Patch
M src/wasm/encoder.cc View 1 2 3 4 5 chunks +16 lines, -13 lines 0 comments Download
M src/wasm/module-decoder.cc View 1 2 3 4 7 chunks +53 lines, -29 lines 0 comments Download
M src/wasm/wasm-macro-gen.h View 1 2 3 4 1 chunk +19 lines, -0 lines 0 comments Download
M src/wasm/wasm-module.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +42 lines, -46 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +14 lines, -2 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 1 2 3 2 chunks +0 lines, -39 lines 0 comments Download
M test/mjsunit/wasm/adapter-frame.js View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M test/mjsunit/wasm/calls.js View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M test/mjsunit/wasm/divrem-trap.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/export-table.js View 1 2 3 4 5 6 7 3 chunks +24 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/ffi.js View 1 2 3 4 3 chunks +6 lines, -6 lines 0 comments Download
M test/mjsunit/wasm/ffi-error.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/function-prototype.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/gc-frame.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/import-table.js View 1 2 3 4 4 chunks +9 lines, -9 lines 0 comments Download
M test/mjsunit/wasm/indirect-calls.js View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/instantiate-module-basic.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/instantiate-run-basic.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/module-memory.js View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/params.js View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/stack.js View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
M test/mjsunit/wasm/stackwalk.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/start-function.js View 1 2 3 4 4 chunks +9 lines, -9 lines 0 comments Download
M test/mjsunit/wasm/test-wasm-module-builder.js View 1 2 3 4 9 chunks +13 lines, -13 lines 0 comments Download
M test/mjsunit/wasm/unreachable.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/wasm/verify-function-simple.js View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M test/mjsunit/wasm/wasm-constants.js View 1 2 3 4 5 6 7 3 chunks +32 lines, -4 lines 0 comments Download
M test/mjsunit/wasm/wasm-module-builder.js View 1 2 3 4 3 chunks +7 lines, -6 lines 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 1 2 3 4 44 chunks +230 lines, -207 lines 0 comments Download

Depends on Patchset:

Issue 1830663002 Patch 360001

Messages

Total messages: 12 (6 generated)
titzer
4 years, 8 months ago (2016-04-19 11:28:37 UTC) #1
rossberg
lgtm
4 years, 8 months ago (2016-04-19 12:27:10 UTC) #2
ahaas
lgtm
4 years, 8 months ago (2016-04-20 08:03:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896863003/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896863003/240001
4 years, 7 months ago (2016-04-29 09:16:50 UTC) #8
commit-bot: I haz the power
Committed patchset #13 (id:240001)
4 years, 7 months ago (2016-04-29 09:39:31 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:03:31 UTC) #12
Message was sent while issue was closed. 
Patchset 13 (id:??) landed as
https://crrev.com/ee03b7217b040a0f51c41c59a6b861979eefac89
Cr-Commit-Position: refs/heads/master@{#35897}

Powered by Google App Engine
This is Rietveld 408576698