Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 1896833002: Initialize Capabilities.chromium_image_rgb_emulation for gles2 (Closed)

Created:
4 years, 8 months ago by perkj_chrome
Modified:
4 years, 8 months ago
Reviewers:
erikchen
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize Capabilities.chromium_image_rgb_emulation for gles2 This is missed in https://codereview.chromium.org/1870483003 "Add command buffer support for GL_RGB CHROMIUM image emulation." and leads to lots of ASAN problem in MSAN. See https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/9525 BUG=595948 TBR=erikchen@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/89c999c6a291fd15e3030faee393611703f6a9a3 Cr-Commit-Position: refs/heads/master@{#387898}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gpu/command_buffer/common/capabilities.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
perkj_chrome
please
4 years, 8 months ago (2016-04-18 12:47:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896833002/1
4 years, 8 months ago (2016-04-18 12:47:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 13:50:26 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/89c999c6a291fd15e3030faee393611703f6a9a3 Cr-Commit-Position: refs/heads/master@{#387898}
4 years, 8 months ago (2016-04-18 13:51:19 UTC) #7
erikchen
4 years, 8 months ago (2016-04-18 16:26:49 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698