Add TestExtensionsBrowserClient, move ProcessManagerTest to //extensions

Add TestExtensionsBrowserClient, move ProcessManagerTest to //extensions

Rewrite ProcessManagerTest to eliminate the TestingProfile dependency and switch to TestBrowserContext.

This requires an ExtensionsBrowserClient that knows how to associate an incognito context with a non-incognito context. I added this in hopes it would be useful for converting other tests away from TestingProfile.

BUG=315855
TEST=unit_tests ProcessManager*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255990

[James Cook, 2014-03-07 01:04:08]

yoz, PTAL

I could have let this test continue to rely on
chrome/test/base/testing_profile.h but I decided to see how much work it was to
convert to TestBrowserContext. It's a moderate amount of work.

https://codereview.chromium.org/189683002/diff/1/extensions/browser/test_exte...
File extensions/browser/test_extensions_browser_client.h (right):

https://codereview.chromium.org/189683002/diff/1/extensions/browser/test_exte...
extensions/browser/test_extensions_browser_client.h:16: class
TestExtensionsBrowserClient : public ExtensionsBrowserClient {
This file isn't really a copy of ShellExtensionsBrowserClient but git thinks it
is.  If I set the similarity higher for the upload then svn doesn't realize the
process_manager_unittest.cc file is a move. :-(

[Yoyo Zhou, 2014-03-07 21:57:14]

LGTM

https://chromiumcodereview.appspot.com/189683002/diff/20001/extensions/browse...
File extensions/browser/process_manager_unittest.cc (right):

https://chromiumcodereview.appspot.com/189683002/diff/20001/extensions/browse...
extensions/browser/process_manager_unittest.cc:130: TEST_F(ProcessManagerTest,
ProcessGrouping) {
I'm slightly concerned that this test uses two TestBrowserContexts while the
TestExtensionsBrowserClient looks designed for the case of only 1 main
BrowserContext. Can you add a comment somewhere appropriate about this?

[James Cook, 2014-03-07 22:16:25]

https://chromiumcodereview.appspot.com/189683002/diff/20001/extensions/browse...
File extensions/browser/process_manager_unittest.cc (right):

https://chromiumcodereview.appspot.com/189683002/diff/20001/extensions/browse...
extensions/browser/process_manager_unittest.cc:130: TEST_F(ProcessManagerTest,
ProcessGrouping) {
On 2014/03/07 21:57:15, Yoyo Zhou wrote:
> I'm slightly concerned that this test uses two TestBrowserContexts while the
> TestExtensionsBrowserClient looks designed for the case of only 1 main
> BrowserContext. Can you add a comment somewhere appropriate about this?

Done.

[James Cook, 2014-03-07 22:20:46]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-03-07 22:24:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/189683002/50001

[commit-bot: I haz the power, 2014-03-08 11:07:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/189683002/50001

[commit-bot: I haz the power, 2014-03-08 14:18:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-08 14:18:38]

Retried try job too often on mac_rel for step(s) telemetry_perf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[James Cook, 2014-03-09 16:06:00]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-03-09 16:06:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/189683002/70001

[commit-bot: I haz the power, 2014-03-09 18:09:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-09 18:09:18]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[James Cook, 2014-03-10 04:15:51]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-03-10 04:16:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/189683002/70001

[commit-bot: I haz the power, 2014-03-10 09:42:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-10 09:42:17]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[James Cook, 2014-03-10 15:56:19]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-03-10 17:09:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/189683002/70001

[commit-bot: I haz the power, 2014-03-10 17:45:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/189683002/70001

[commit-bot: I haz the power, 2014-03-10 18:34:11]

Change committed as 255990