third_party/WebKit/Source/web/mac/WebSubstringUtil.mm - Issue 1896793002: Rename (updateLayout/updateStyle).*.() to updateStyleAndLayout.*.()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

Issue 1896793002: Rename (updateLayout/updateStyle).*.() to updateStyleAndLayout.*.() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/testing/Internals.idl ('K') | « third_party/WebKit/Source/web/WebViewImpl.cpp ('k') | third_party/WebKit/Source/web/tests/DocumentLoadingRenderingTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

diff --git a/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm b/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

index 6cd6d6625410d4ff9c2755e5960fed33f365b43c..aee528403806d9ba04e35ccc39f86ea209b24889 100644

--- a/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

+++ b/third_party/WebKit/Source/web/mac/WebSubstringUtil.mm

@@ -66,9 +66,9 @@ static NSAttributedString* attributedSubstringFromRange(const EphemeralRange& ra

unsigned position = 0;

- // TODO(dglazkov): The use of updateLayoutIgnorePendingStylesheets needs to be audited.

+ // TODO(dglazkov): The use of updateStyleAndLayoutIgnorePendingStylesheets needs to be audited.

// see http://crbug.com/590369 for more details.

- range.startPosition().document()->updateLayoutIgnorePendingStylesheets();

+ range.startPosition().document()->updateStyleAndLayoutIgnorePendingStylesheets();

for (TextIterator it(range.startPosition(), range.endPosition()); !it.atEnd() && [string length] < length; it.advance()) {

unsigned numCharacters = it.length();