third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp - Issue 1896793002: Rename (updateLayout/updateStyle).*.() to updateStyleAndLayout.*.()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

Issue 1896793002: Rename (updateLayout/updateStyle).*.() to updateStyleAndLayout.*.() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/FrameSelection.cpp ('k') | third_party/WebKit/Source/core/editing/InputMethodController.cpp » ('j') | third_party/WebKit/Source/core/testing/Internals.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp b/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

index 683000de5fbc194522bbf0682919f01009c6af30..3d9312b18fa9b97a57baa52098ebee93b62b2689 100644

--- a/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

+++ b/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

@@ -101,7 +101,7 @@ TEST_F(FrameSelectionTest, InvalidateCaretRect)

EXPECT_FALSE(selection().isCaretBoundsDirty());

document().body()->removeChild(text);

- document().updateLayoutIgnorePendingStylesheets();

+ document().updateStyleAndLayoutIgnorePendingStylesheets();

selection().setCaretRectNeedsUpdate();

EXPECT_TRUE(selection().isCaretBoundsDirty());

selection().invalidateCaretRect();

@@ -178,7 +178,7 @@ TEST_F(FrameSelectionTest, InvalidatePreviousCaretAfterRemovingLastCharacter)

// This line is the objective of this test.

// As removing the last character, early previousCaret invalidation is executed.

EXPECT_FALSE(isPreviousCaretDirtyForTesting());

- document().updateLayoutIgnorePendingStylesheets();

+ document().updateStyleAndLayoutIgnorePendingStylesheets();

selection().setCaretRectNeedsUpdate();

EXPECT_TRUE(selection().isCaretBoundsDirty());

EXPECT_FALSE(isPreviousCaretDirtyForTesting());