third_party/WebKit/Source/core/editing/EditingUtilities.cpp - Issue 1896793002: Rename (updateLayout/updateStyle).*.() to updateStyleAndLayout.*.()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/EditingUtilities.cpp

Issue 1896793002: Rename (updateLayout/updateStyle).*.() to updateStyleAndLayout.*.() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/DragCaretController.cpp ('k') | third_party/WebKit/Source/core/editing/Editor.cpp » ('j') | third_party/WebKit/Source/core/testing/Internals.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/EditingUtilities.cpp

diff --git a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp

index 89ec17582f20ae4d0f2b7eb2df14aa3412a12d71..9437e08ef8992f86989b82630825505e2c50070a 100644

--- a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp

+++ b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp

@@ -268,7 +268,7 @@ bool isEditablePosition(const Position& p, EditableType editableType, EUpdateSty

if (!node)

return false;

if (updateStyle == UpdateStyle)

- node->document().updateLayoutIgnorePendingStylesheets();

+ node->document().updateStyleAndLayoutIgnorePendingStylesheets();

else

DCHECK_EQ(updateStyle, DoNotUpdateStyle);

@@ -1603,7 +1603,7 @@ template <typename Strategy>

static EphemeralRangeTemplate<Strategy> normalizeRangeAlgorithm(const EphemeralRangeTemplate<Strategy>& range)

{

DCHECK(range.isNotNull());

- range.document().updateLayoutIgnorePendingStylesheets();

+ range.document().updateStyleAndLayoutIgnorePendingStylesheets();

// TODO(yosin) We should not call |parentAnchoredEquivalent()|, it is

// redundant.