third_party/WebKit/Source/core/animation/EffectInput.cpp - Issue 1896793002: Rename (updateLayout/updateStyle).*.() to updateStyleAndLayout.*.()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/EffectInput.cpp

Issue 1896793002: Rename (updateLayout/updateStyle).*.() to updateStyleAndLayout.*.() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/web-animations-api/element-animate-no-style-recalc.html ('k') | third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp » ('j') | third_party/WebKit/Source/core/testing/Internals.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/EffectInput.cpp

diff --git a/third_party/WebKit/Source/core/animation/EffectInput.cpp b/third_party/WebKit/Source/core/animation/EffectInput.cpp

index d5226762ec115b23b84e980c7cddc96153edd4c8..092dc6d5e23f242d0b0a9785eeca8752991f0f51 100644

--- a/third_party/WebKit/Source/core/animation/EffectInput.cpp

+++ b/third_party/WebKit/Source/core/animation/EffectInput.cpp

@@ -102,7 +102,7 @@ EffectModel* createEffectModelFromKeyframes(Element& element, const StringKeyfra

{

// TODO(alancutter): Remove this once composited animations no longer depend on AnimatableValues.

if (encounteredCompositableProperty && element.inActiveDocument())

- element.document().updateLayoutTreeForNode(&element);

+ element.document().updateStyleAndLayoutTreeForNode(&element);

StringKeyframeEffectModel* keyframeEffectModel = StringKeyframeEffectModel::create(keyframes, LinearTimingFunction::shared());

if (!RuntimeEnabledFeatures::cssAdditiveAnimationsEnabled()) {