third_party/WebKit/LayoutTests/fast/css/modify-stylesheet-minimal-recalc-style.html - Issue 1896793002: Rename (updateLayout/updateStyle).*.() to updateStyleAndLayout.*.()

Unified Diff: third_party/WebKit/LayoutTests/fast/css/modify-stylesheet-minimal-recalc-style.html

Issue 1896793002: Rename (updateLayout/updateStyle).*.() to updateStyleAndLayout.*.() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/mask-missing-image-crash.html ('k') | third_party/WebKit/LayoutTests/fast/css/modify-stylesheet-minimal-recalc-style-expected.txt » ('j') | third_party/WebKit/Source/core/testing/Internals.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/css/modify-stylesheet-minimal-recalc-style.html

diff --git a/third_party/WebKit/LayoutTests/fast/css/modify-stylesheet-minimal-recalc-style.html b/third_party/WebKit/LayoutTests/fast/css/modify-stylesheet-minimal-recalc-style.html

index 40814c59175bf4f780e1183fbe7436752fbac9a4..e7b06d7f0533d6cd29a36f227aedde9e7b89a880 100644

--- a/third_party/WebKit/LayoutTests/fast/css/modify-stylesheet-minimal-recalc-style.html

+++ b/third_party/WebKit/LayoutTests/fast/css/modify-stylesheet-minimal-recalc-style.html

@@ -36,28 +36,28 @@ if (window.internals) {

// Add non-existant classname.

forceRecalc();

sheet.textContent = ".nonexistant { color: red; }";

- shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "0");

+ shouldBe("internals.updateStyleAndLayoutAndReturnAffectedElementCount()", "0");

// Add two existing classnames.

forceRecalc();

sheet.textContent = ".bar { color: red; }\n.baz { color: red; }";

- shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "6");

+ shouldBe("internals.updateStyleAndLayoutAndReturnAffectedElementCount()", "6");

// Remove the classnames from the previous step.

forceRecalc();

sheet.textContent = "";

- shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "6");

+ shouldBe("internals.updateStyleAndLayoutAndReturnAffectedElementCount()", "6");

// Test innerHTML.

forceRecalc();

sheet.innerHTML = ".bar { color: red; }\n.baz { color: red; }";

- shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "6");

+ shouldBe("internals.updateStyleAndLayoutAndReturnAffectedElementCount()", "6");

// Test deleteRule

forceRecalc();

sheet.sheet.deleteRule(0); // Deletes .bar rule.

// FIXME: Ideally we'd do StyleInvalidationAnalysis here and only recalc 3 bar's, 3 baz's + documentElement

- shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "43");

+ shouldBe("internals.updateStyleAndLayoutAndReturnAffectedElementCount()", "43");

shouldBe("getComputedStyle(document.querySelector('.foo')).color", '"rgb(0, 0, 0)"');

shouldBe("getComputedStyle(document.querySelector('.baz')).color", '"rgb(255, 0, 0)"');

@@ -67,7 +67,7 @@ if (window.internals) {

forceRecalc();

sheet.sheet.insertRule(".foo { color: red; }", 0);

// FIXME: Ideally we'd do StyleInvalidationAnalysis here and only recalc 3 foo's, 3 baz's + documentElement

- shouldBe("internals.updateStyleAndReturnAffectedElementCount()", "59");

+ shouldBe("internals.updateStyleAndLayoutAndReturnAffectedElementCount()", "59");

shouldBe("getComputedStyle(document.querySelector('.foo')).color", '"rgb(255, 0, 0)"');

shouldBe("getComputedStyle(document.querySelector('.baz')).color", '"rgb(255, 0, 0)"');