third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js - Issue 1896793002: Rename (updateLayout/updateStyle).*.() to updateStyleAndLayout.*.()

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 1896793002: Rename (updateLayout/updateStyle).*.() to updateStyleAndLayout.*.() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js ('K') | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js ('k') | third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

index c727c845b9aaf24e3e7be6edcaf47566085f0a02..1dbce54f44530e274766e40788d1b312092a32e4 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

@@ -70,7 +70,7 @@ WebInspector.TimelineUIUtils._initEventStyles = function()

eventStyles[recordTypes.HitTest] = new WebInspector.TimelineRecordStyle(WebInspector.UIString("Hit Test"), categories["rendering"]);

eventStyles[recordTypes.ScheduleStyleRecalculation] = new WebInspector.TimelineRecordStyle(WebInspector.UIString("Schedule Style Recalculation"), categories["rendering"], true);

eventStyles[recordTypes.RecalculateStyles] = new WebInspector.TimelineRecordStyle(WebInspector.UIString("Recalculate Style"), categories["rendering"]);

- eventStyles[recordTypes.UpdateLayoutTree] = new WebInspector.TimelineRecordStyle(WebInspector.UIString("Recalculate Style"), categories["rendering"]);

+ eventStyles[recordTypes.UpdateStyleAndLayoutTree] = new WebInspector.TimelineRecordStyle(WebInspector.UIString("Recalculate Style"), categories["rendering"]);

eventStyles[recordTypes.InvalidateLayout] = new WebInspector.TimelineRecordStyle(WebInspector.UIString("Invalidate Layout"), categories["rendering"], true);

eventStyles[recordTypes.Layout] = new WebInspector.TimelineRecordStyle(WebInspector.UIString("Layout"), categories["rendering"]);

eventStyles[recordTypes.PaintSetup] = new WebInspector.TimelineRecordStyle(WebInspector.UIString("Paint Setup"), categories["painting"]);

@@ -804,7 +804,7 @@ WebInspector.TimelineUIUtils._buildTraceEventDetailsSynchronously = function(eve

if (url)

contentHelper.appendElementRow(WebInspector.UIString("Stylesheet URL"), WebInspector.linkifyResourceAsNode(url));

break;

- case recordTypes.UpdateLayoutTree: // We don't want to see default details.

+ case recordTypes.UpdateStyleAndLayoutTree: // We don't want to see default details.

case recordTypes.RecalculateStyles:

contentHelper.appendTextRow(WebInspector.UIString("Elements Affected"), event.args["elementCount"]);

break;

@@ -1081,7 +1081,7 @@ WebInspector.TimelineUIUtils._generateCauses = function(event, target, relatedNo

case recordTypes.FireIdleCallback:

callSiteStackLabel = WebInspector.UIString("Idle Callback Requested");

break;

- case recordTypes.UpdateLayoutTree:

+ case recordTypes.UpdateStyleAndLayoutTree:

case recordTypes.RecalculateStyles:

stackLabel = WebInspector.UIString("Recalculation Forced");

break;