third_party/WebKit/Source/core/inspector/LayoutEditor.cpp - Issue 1896793002: Rename (updateLayout/updateStyle).*.() to updateStyleAndLayout.*.()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/LayoutEditor.cpp

Issue 1896793002: Rename (updateLayout/updateStyle).*.() to updateStyleAndLayout.*.() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/LayoutEditor.cpp

diff --git a/third_party/WebKit/Source/core/inspector/LayoutEditor.cpp b/third_party/WebKit/Source/core/inspector/LayoutEditor.cpp

index 3b1a748b2d1801b513ddc80081c8e538bd978243..d9b50c2c28d0e34c27d2122056661deecad96470 100644

--- a/third_party/WebKit/Source/core/inspector/LayoutEditor.cpp

+++ b/third_party/WebKit/Source/core/inspector/LayoutEditor.cpp

@@ -222,13 +222,13 @@ bool LayoutEditor::growInside(String propertyName, CSSPrimitiveValue* value)

TrackExceptionState exceptionState;

elementStyle->setProperty(propertyName, newValue, "important", exceptionState);

- m_element->ownerDocument()->updateLayout();

+ m_element->ownerDocument()->updateStyleAndLayout();

FloatQuad content2, padding2, border2, margin2;

InspectorHighlight::buildNodeQuads(m_element.get(), &content2, &padding2, &border2, &margin2);

elementStyle->setProperty(propertyName, initialValue, initialPriority, exceptionState);

- m_element->ownerDocument()->updateLayout();

+ m_element->ownerDocument()->updateStyleAndLayout();

float eps = 0.0001;

FloatRect boundingBox1, boundingBox2;