Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issue 1896743002: Add travis-ci support (Closed)

Created:
4 years, 8 months ago by wychen
Modified:
4 years, 8 months ago
Reviewers:
mdjones
Base URL:
git@github.com:chromium/dom-distiller.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add travis-ci support We've been using drone.io as the continuous integration service, but Chrome is no longer supported on Ubuntu 12.04, which is the only convenient option there. Bump minimum version required for Chrome to 49 due to revision 84cfcd2. Some tests about image size would fail in version 46, but work in 49. Chrome also dropped 32-bit support, so specify 64-bit version for apt. BUG=604177 R=mdjones@chromium.org Committed: c3edb386a994b246b4dacd1d40dd0c576df581fc

Patch Set 1 #

Patch Set 2 : run in sandbox #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
A .travis.yml View 1 1 chunk +13 lines, -0 lines 0 comments Download
M README.md View 1 chunk +3 lines, -3 lines 0 comments Download
M install-build-deps.sh View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
wychen
ptal
4 years, 8 months ago (2016-04-17 08:41:28 UTC) #2
mdjones
lgtm
4 years, 8 months ago (2016-04-19 16:16:04 UTC) #3
wychen
4 years, 8 months ago (2016-04-19 18:06:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c3edb386a994b246b4dacd1d40dd0c576df581fc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698