Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4990)

Unified Diff: chrome/browser/chrome_browser_main.h

Issue 18967002: Small cleanup for ChromeBrowserMain: (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_browser_main.h
===================================================================
--- chrome/browser/chrome_browser_main.h (revision 210624)
+++ chrome/browser/chrome_browser_main.h (working copy)
@@ -101,6 +101,7 @@
}
Profile* profile() { return profile_; }
+ bool do_first_run_tasks() const { return do_first_run_tasks_; }
const PrefService* local_state() const { return local_state_; }
@@ -119,6 +120,15 @@
// Returns true if the user opted in to sending metric reports.
bool IsMetricsReportingEnabled();
+ // Record time from process startup to present time in an UMA histogram.
+ // |is_first_run| - is the current launch part of a first run.
+ void RecordBrowserStartupTime(bool is_first_run);
+
+ // Records a time value to an UMA histogram in the context of the
+ // PreReadExperiment field-trial. This also reports to the appropriate
+ // sub-histogram (_PreRead(Enabled|Disabled)).
+ void RecordPreReadExperimentTime(const char* name, base::TimeDelta time);
+
// Methods for Main Message Loop -------------------------------------------
int PreCreateThreadsImpl();
@@ -174,7 +184,6 @@
scoped_ptr<ChromeProcessSingleton> process_singleton_;
#endif
scoped_ptr<first_run::MasterPrefs> master_prefs_;
- bool record_search_engine_;
TranslateManager* translate_manager_;
Profile* profile_;
bool run_message_loop_;
@@ -204,23 +213,4 @@
DISALLOW_COPY_AND_ASSIGN(ChromeBrowserMainParts);
};
-// Records the conditions that can prevent Breakpad from generating and
-// sending crash reports. The presence of a Breakpad handler (after
-// attempting to initialize crash reporting) and the presence of a debugger
-// are registered with the UMA metrics service.
-void RecordBreakpadStatusUMA(MetricsService* metrics);
-
-// Displays a warning message if some minimum level of OS support is not
-// present on the current platform.
-void WarnAboutMinimumSystemRequirements();
-
-// Record time from process startup to present time in an UMA histogram.
-// |is_first_run| - is the current launch part of a first run.
-void RecordBrowserStartupTime(bool is_first_run);
-
-// Records a time value to an UMA histogram in the context of the
-// PreReadExperiment field-trial. This also reports to the appropriate
-// sub-histogram (_PreRead(Enabled|Disabled)).
-void RecordPreReadExperimentTime(const char* name, base::TimeDelta time);
-
#endif // CHROME_BROWSER_CHROME_BROWSER_MAIN_H_

Powered by Google App Engine
This is Rietveld 408576698