Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2121)

Unified Diff: chrome/browser/chrome_browser_main_mac.mm

Issue 18967002: Small cleanup for ChromeBrowserMain: (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_browser_main_mac.mm
===================================================================
--- chrome/browser/chrome_browser_main_mac.mm (revision 210624)
+++ chrome/browser/chrome_browser_main_mac.mm (working copy)
@@ -8,7 +8,6 @@
#include <sys/sysctl.h>
#include "base/command_line.h"
-#include "base/debug/debugger.h"
#include "base/files/file_path.h"
#include "base/mac/bundle_locations.h"
#include "base/mac/mac_util.h"
@@ -150,21 +149,6 @@
} // namespace
-void RecordBreakpadStatusUMA(MetricsService* metrics) {
- metrics->RecordBreakpadRegistration(IsCrashReporterEnabled());
- metrics->RecordBreakpadHasDebugger(base::debug::BeingDebugged());
-}
-
-void WarnAboutMinimumSystemRequirements() {
- // Nothing to check for on Mac right now.
-}
-
-// From browser_main_win.h, stubs until we figure out the right thing...
-
-int DoUninstallTasks(bool chrome_still_running) {
- return content::RESULT_CODE_NORMAL_EXIT;
-}
-
// ChromeBrowserMainPartsMac ---------------------------------------------------
ChromeBrowserMainPartsMac::ChromeBrowserMainPartsMac(
@@ -286,6 +270,11 @@
ChromeBrowserMainPartsPosix::PreProfileInit();
}
+void ChromeBrowserMainPartsMac::PostProfileInit() {
+ ChromeBrowserMainPartsPosix::PostProfileInit();
+ metrics->RecordBreakpadRegistration(IsCrashReporterEnabled());
+}
+
void ChromeBrowserMainPartsMac::DidEndMainMessageLoop() {
AppController* appController = [NSApp delegate];
[appController didEndMainMessageLoop];

Powered by Google App Engine
This is Rietveld 408576698