Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 189663011: Fix assertion failure caused by external strings. (Closed)

Created:
6 years, 9 months ago by Yang
Modified:
6 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Fix assertion failure caused by external strings. This fixes two issues: - Update externalize-string-extension to the behavior of the API (see r18285) - Convert cons strings in old pointer space to short external strings as expected by Heap::AllowedToBeMigrated, regardless of alignment. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19755

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M src/extensions/externalize-string-extension.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.cc View 2 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
This fixes some GC stress failures.
6 years, 9 months ago (2014-03-10 11:42:05 UTC) #1
Michael Starzinger
LGTM.
6 years, 9 months ago (2014-03-10 11:47:14 UTC) #2
Yang
6 years, 9 months ago (2014-03-10 12:08:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19755 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698