Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 1896613002: Move all args to per-request for the worker, and add a test (Closed)

Created:
4 years, 8 months ago by jakemac
Modified:
4 years, 8 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org, Siggi Cherem (dart-lang)
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move all args to per-request for the worker, and add a test BUG= R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/39d038366f9080bf00ab242202a19d212d5372f5

Patch Set 1 #

Patch Set 2 : Refactor, executable now has zero opinion about startup vs work request args" #

Patch Set 3 : rebase #

Total comments: 2

Patch Set 4 : use exit code 70 for internal errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -112 lines) Patch
M bin/dartdevc.dart View 1 2 3 1 chunk +82 lines, -8 lines 0 comments Download
M lib/src/compiler/command.dart View 1 2 chunks +12 lines, -97 lines 0 comments Download
M test/worker/worker_test.dart View 1 2 4 chunks +19 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jakemac
4 years, 8 months ago (2016-04-15 21:46:32 UTC) #2
Jennifer Messerly
LGTM, nice refactor :) https://codereview.chromium.org/1896613002/diff/40001/bin/dartdevc.dart File bin/dartdevc.dart (right): https://codereview.chromium.org/1896613002/diff/40001/bin/dartdevc.dart#newcode122 bin/dartdevc.dart:122: return 1; BTW, this was ...
4 years, 8 months ago (2016-04-18 18:08:41 UTC) #3
jakemac
https://codereview.chromium.org/1896613002/diff/40001/bin/dartdevc.dart File bin/dartdevc.dart (right): https://codereview.chromium.org/1896613002/diff/40001/bin/dartdevc.dart#newcode122 bin/dartdevc.dart:122: return 1; On 2016/04/18 18:08:41, John Messerly wrote: > ...
4 years, 8 months ago (2016-04-18 18:14:26 UTC) #4
jakemac
4 years, 8 months ago (2016-04-18 18:17:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
39d038366f9080bf00ab242202a19d212d5372f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698