Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1896543002:
[Media, UI] Use 3-line style to show metadata in MediaNotification (Closed)
|
Created:
4 years, 8 months ago by Zhiqiang Zhang (Slow) Modified:
4 years, 8 months ago Reviewers:
mlamouri (slow - plz ping) CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Media, UI] Use 3-line style to show metadata in MediaNotification
This CL uses the 3-line style in MediaNotification to better present
media metadata.
BUG=599937
Committed: https://crrev.com/874b02830b1b3f56f5aac6fd341b0ed4a07ebb84
Cr-Commit-Position: refs/heads/master@{#388879}
Patch Set 1 #Patch Set 2 : fix OS version checking for N #
Total comments: 6
Patch Set 3 : addressed comments #Messages
Total messages: 19 (8 generated)
The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896543002/1
zqzhang@chromium.org changed reviewers: + mlamouri@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/1896543002/diff/20001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java (right): https://codereview.chromium.org/1896543002/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java:766: if (Build.VERSION.RELEASE.startsWith("N")) { Can't you use the SDK version? and use >=? https://codereview.chromium.org/1896543002/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java:772: builder.setContentText(mMediaNotificationInfo.origin); What happens if you set a SubText instead of a ContentText?
https://codereview.chromium.org/1896543002/diff/20001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java (right): https://codereview.chromium.org/1896543002/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java:766: if (Build.VERSION.RELEASE.startsWith("N")) { On 2016/04/19 15:06:06, Mounir Lamouri wrote: > Can't you use the SDK version? and use >=? I tried but failed. Currently, Build.VERSION.SDK_INT is still 23 on N. https://codereview.chromium.org/1896543002/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java:772: builder.setContentText(mMediaNotificationInfo.origin); On 2016/04/19 15:06:06, Mounir Lamouri wrote: > What happens if you set a SubText instead of a ContentText? It won't show if ContentText is null, and there will be a gap between the two lines if ContentText is "".
lgtm with comments applied https://codereview.chromium.org/1896543002/diff/20001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java (right): https://codereview.chromium.org/1896543002/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java:766: if (Build.VERSION.RELEASE.startsWith("N")) { On 2016/04/19 at 15:33:07, Zhiqiang Zhang wrote: > On 2016/04/19 15:06:06, Mounir Lamouri wrote: > > Can't you use the SDK version? and use >=? > > I tried but failed. Currently, Build.VERSION.SDK_INT is still 23 on N. Good point! Let's use `Build.VERSION.CODENAME.equals("N")`: `TextUtils.equals(Build.VERSION.CODENAME, "N")` https://codereview.chromium.org/1896543002/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java:777: } What about: ``` if (ANDROID_N || !artistAndAlbumText.isEmpty()) { builder.setContentText(artistAndAlbumText); builder.setSubText(mMediaNotificationInfo.origin); } else { builder.setContentText(mMediaNotificationInfo.origin); } ```
The CQ bit was checked by zqzhang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mlamouri@chromium.org Link to the patchset: https://codereview.chromium.org/1896543002/#ps40001 (title: "addressed comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896543002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896543002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by zqzhang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896543002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896543002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [Media, UI] Use 3-line style to show metadata in MediaNotification This CL uses the 3-line style in MediaNotification to better present media metadata. BUG=599937 ========== to ========== [Media, UI] Use 3-line style to show metadata in MediaNotification This CL uses the 3-line style in MediaNotification to better present media metadata. BUG=599937 Committed: https://crrev.com/874b02830b1b3f56f5aac6fd341b0ed4a07ebb84 Cr-Commit-Position: refs/heads/master@{#388879} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/874b02830b1b3f56f5aac6fd341b0ed4a07ebb84 Cr-Commit-Position: refs/heads/master@{#388879} |
