Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1896473002: Expose IDBKeyRange.includes() in stable (Closed)

Created:
4 years, 8 months ago by jsbell
Modified:
4 years, 8 months ago
Reviewers:
cmumford, Rick Byers
CC:
chromium-reviews, blink-reviews, haraken, jsbell+idb_chromium.org, cmumford
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Messages

Total messages: 17 (6 generated)
jsbell
cmumford@ - can you take a look? It's a very complex patch. ;-)
4 years, 8 months ago (2016-04-15 16:49:45 UTC) #2
cmumford
lgtm
4 years, 8 months ago (2016-04-15 17:01:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896473002/1
4 years, 8 months ago (2016-04-15 17:02:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/169199)
4 years, 8 months ago (2016-04-15 17:11:14 UTC) #7
jsbell
Oops, need API_OWNERS stamp now. *rolls dice* rbyers@ - can you approve?
4 years, 8 months ago (2016-04-15 17:13:28 UTC) #9
Rick Byers
Webexposed LGTM
4 years, 8 months ago (2016-04-17 16:54:27 UTC) #10
Rick Byers
Webexposed LGTM
4 years, 8 months ago (2016-04-17 16:54:29 UTC) #11
Rick Byers
Webexposed LGTM
4 years, 8 months ago (2016-04-17 16:54:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896473002/1
4 years, 8 months ago (2016-04-18 16:35:47 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 17:49:07 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 17:51:41 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b5b94d6d93c28d563c3dfbaa73554e9a5f5f2fc
Cr-Commit-Position: refs/heads/master@{#387946}

Powered by Google App Engine
This is Rietveld 408576698