chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.h - Issue 1896463003: WebUI: Add JavaScript lifecycle-control to WebUIMessageHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.h

Issue 1896463003: WebUI: Add JavaScript lifecycle-control to WebUIMessageHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/md_downloads/md_downloads_dom_handler_unittest.cc ('k') | chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.cc » ('j') | content/public/browser/web_ui_message_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.h

diff --git a/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.h b/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.h

index e3f5e8229c74825541a41f26c1e456e1a91e5023..3fb3706c5248205c6d5e4ae17992302017eb8923 100644

--- a/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.h

+++ b/chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.h

@@ -31,7 +31,8 @@ class EasyUnlockSettingsHandler : public ::settings::SettingsPageUIHandler,

// SettingsPageUIHandler:

void RegisterMessages() override;

- void RenderViewReused() override;

+ void OnJavascriptAllowed() override;

+ void OnJavascriptDisallowed() override;

// EasyUnlockServiceObserver:

void OnTurnOffOperationStatusChanged() override;

@@ -57,8 +58,6 @@ class EasyUnlockSettingsHandler : public ::settings::SettingsPageUIHandler,

PrefChangeRegistrar profile_pref_registrar_;

- bool observers_registered_;

DISALLOW_COPY_AND_ASSIGN(EasyUnlockSettingsHandler);

};