Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1896443002: Revert of mac: Remove POSIX shared memory. (Closed)

Created:
4 years, 8 months ago by erikchen
Modified:
4 years, 8 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, gavinp+memory_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp50_base
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mac: Remove POSIX shared memory. (patchset #1 id:1 of https://codereview.chromium.org/1893603002/ ) Reason for revert: Actually, it was responsible for triggering the broken logic. We can't reland this until either mojo is fixed to be able to pass null mach ports, or the mojo experiment is disabled. Original issue's description: > Reland of mac: Remove POSIX shared memory. (patchset #1 id:1 of https://codereview.chromium.org/1890023002/ ) > > Reason for revert: > The original CL was reverted on suspicion of causing a crash. It was not responsible. > > https://bugs.chromium.org/p/chromium/issues/detail?id=603452 > > Original issue's description: > > Revert of mac: Remove POSIX shared memory. (patchset #8 id:140001 of https://codereview.chromium.org/1867733002/ ) > > > > Reason for revert: > > Looking for the cause of https://crbug.com/603452. > > > > Original issue's description: > > > mac: Remove POSIX shared memory. > > > > > > There are no more consumers. > > > > > > BUG=568284 > > > > > > Committed: https://crrev.com/acc9ec9e73902650962df0c24a209abfc2a827ef > > > Cr-Commit-Position: refs/heads/master@{#387050} > > > > TBR=mark@chromium.org,mseaborn@chromium.org,avi@chromium.org,tsepez@chromium.org,amistry@chromium.org,thakis@chromium.org,erikchen@chromium.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=568284 > > NOPRESUBMIT=true > > > > Committed: https://crrev.com/6b5d3ac9b231cbd56dcbea0bcdf94b3e9178e738 > > Cr-Commit-Position: refs/heads/master@{#387482} > > TBR=mark@chromium.org,mseaborn@chromium.org,avi@chromium.org,tsepez@chromium.org,amistry@chromium.org,thakis@chromium.org,shrike@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=568284 > > Committed: https://crrev.com/0739bacd2a6e671c54bd1d1e67b04a242404b87a > Cr-Commit-Position: refs/heads/master@{#387606} TBR=mark@chromium.org,mseaborn@chromium.org,avi@chromium.org,tsepez@chromium.org,amistry@chromium.org,thakis@chromium.org,shrike@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=568284 Committed: https://crrev.com/48b7edf0faa17600a7cd2735539b336cd68d4d19 Cr-Commit-Position: refs/heads/master@{#387607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+723 lines, -124 lines) Patch
M base/memory/shared_memory.h View 6 chunks +23 lines, -5 lines 0 comments Download
M base/memory/shared_memory_handle.h View 4 chunks +63 lines, -16 lines 0 comments Download
M base/memory/shared_memory_handle_mac.cc View 4 chunks +140 lines, -42 lines 0 comments Download
M base/memory/shared_memory_mac.cc View 8 chunks +241 lines, -20 lines 0 comments Download
M base/memory/shared_memory_unittest.cc View 8 chunks +18 lines, -5 lines 0 comments Download
M components/nacl/loader/nacl_ipc_adapter.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M content/renderer/media/video_capture_message_filter_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ipc/ipc_message_utils.cc View 1 chunk +75 lines, -25 lines 0 comments Download
M mojo/edk/embedder/embedder_unittest.cc View 2 chunks +136 lines, -0 lines 0 comments Download
M mojo/edk/embedder/platform_shared_buffer.cc View 3 chunks +17 lines, -3 lines 0 comments Download
M mojo/edk/embedder/platform_shared_buffer_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
erikchen
Created Revert of mac: Remove POSIX shared memory.
4 years, 8 months ago (2016-04-15 15:47:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896443002/1
4 years, 8 months ago (2016-04-15 15:48:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 15:50:07 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 15:51:16 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48b7edf0faa17600a7cd2735539b336cd68d4d19
Cr-Commit-Position: refs/heads/master@{#387607}

Powered by Google App Engine
This is Rietveld 408576698