Chromium Code Reviews
DescriptionRevert of mac: Remove POSIX shared memory. (patchset #1 id:1 of https://codereview.chromium.org/1893603002/ )
Reason for revert:
Actually, it was responsible for triggering the broken logic. We can't reland this until either mojo is fixed to be able to pass null mach ports, or the mojo experiment is disabled.
Original issue's description:
> Reland of mac: Remove POSIX shared memory. (patchset #1 id:1 of https://codereview.chromium.org/1890023002/ )
>
> Reason for revert:
> The original CL was reverted on suspicion of causing a crash. It was not responsible.
>
> https://bugs.chromium.org/p/chromium/issues/detail?id=603452
>
> Original issue's description:
> > Revert of mac: Remove POSIX shared memory. (patchset #8 id:140001 of https://codereview.chromium.org/1867733002/ )
> >
> > Reason for revert:
> > Looking for the cause of https://crbug.com/603452.
> >
> > Original issue's description:
> > > mac: Remove POSIX shared memory.
> > >
> > > There are no more consumers.
> > >
> > > BUG=568284
> > >
> > > Committed: https://crrev.com/acc9ec9e73902650962df0c24a209abfc2a827ef
> > > Cr-Commit-Position: refs/heads/master@{#387050}
> >
> > TBR=mark@chromium.org,mseaborn@chromium.org,avi@chromium.org,tsepez@chromium.org,amistry@chromium.org,thakis@chromium.org,erikchen@chromium.org
> > # Not skipping CQ checks because original CL landed more than 1 days ago.
> > BUG=568284
> > NOPRESUBMIT=true
> >
> > Committed: https://crrev.com/6b5d3ac9b231cbd56dcbea0bcdf94b3e9178e738
> > Cr-Commit-Position: refs/heads/master@{#387482}
>
> TBR=mark@chromium.org,mseaborn@chromium.org,avi@chromium.org,tsepez@chromium.org,amistry@chromium.org,thakis@chromium.org,shrike@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=568284
>
> Committed: https://crrev.com/0739bacd2a6e671c54bd1d1e67b04a242404b87a
> Cr-Commit-Position: refs/heads/master@{#387606}
TBR=mark@chromium.org,mseaborn@chromium.org,avi@chromium.org,tsepez@chromium.org,amistry@chromium.org,thakis@chromium.org,shrike@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=568284
Committed: https://crrev.com/48b7edf0faa17600a7cd2735539b336cd68d4d19
Cr-Commit-Position: refs/heads/master@{#387607}
Patch Set 1 #
Messages
Total messages: 5 (1 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||