[NTP Snippets] Add tests for scheduling/unscheduling

[NTP Snippets] Add tests for scheduling/unscheduling

BUG=595723
Committed: https://crrev.com/5c0086b4a519d448e269ec3d558aacf4e2e86156
Cr-Commit-Position: refs/heads/master@{#388475}

[Marc Treib, 2016-04-20 09:50:04]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-20 09:50:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1896423002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1896423002/1

[Marc Treib, 2016-04-20 09:50:20]

treib@chromium.org changed reviewers:
+ bauerb@chromium.org

[Marc Treib, 2016-04-20 09:50:20]

PTAL!

[commit-bot: I haz the power, 2016-04-20 10:26:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-20 10:26:10]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-04-20 11:25:57]

lgtm

https://codereview.chromium.org/1896423002/diff/1/components/ntp_snippets/ntp...
File components/ntp_snippets/ntp_snippets_service_unittest.cc (right):

https://codereview.chromium.org/1896423002/diff/1/components/ntp_snippets/ntp...
components/ntp_snippets/ntp_snippets_service_unittest.cc:109: MockScheduler() {}
Nit: I would just remove the default constructor and destructor -- the compiler
is going to generate them anyway, right?

https://codereview.chromium.org/1896423002/diff/1/components/ntp_snippets/ntp...
components/ntp_snippets/ntp_snippets_service_unittest.cc:186: //
CreateSnippetsServiceEnabled checks that Schedule is called.
This is a bit strange, but I guess it works...

[Marc Treib, 2016-04-20 12:03:04]

https://codereview.chromium.org/1896423002/diff/1/components/ntp_snippets/ntp...
File components/ntp_snippets/ntp_snippets_service_unittest.cc (right):

https://codereview.chromium.org/1896423002/diff/1/components/ntp_snippets/ntp...
components/ntp_snippets/ntp_snippets_service_unittest.cc:109: MockScheduler() {}
On 2016/04/20 11:25:57, Bernhard Bauer wrote:
> Nit: I would just remove the default constructor and destructor -- the
compiler
> is going to generate them anyway, right?

Done.

https://codereview.chromium.org/1896423002/diff/1/components/ntp_snippets/ntp...
components/ntp_snippets/ntp_snippets_service_unittest.cc:186: //
CreateSnippetsServiceEnabled checks that Schedule is called.
On 2016/04/20 11:25:57, Bernhard Bauer wrote:
> This is a bit strange, but I guess it works...

Well, suggestions for improvement welcome :)

[Marc Treib, 2016-04-20 12:03:08]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2016-04-20 12:03:09]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/1896423002/#ps20001
(title: "remove empty ctor/dtor")

[commit-bot: I haz the power, 2016-04-20 12:03:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1896423002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1896423002/20001

[commit-bot: I haz the power, 2016-04-20 12:44:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 19:22:45]

Description was changed from

==========
[NTP Snippets] Add tests for scheduling/unscheduling

BUG=595723
==========

to

==========
[NTP Snippets] Add tests for scheduling/unscheduling

BUG=595723

Committed: https://crrev.com/5c0086b4a519d448e269ec3d558aacf4e2e86156
Cr-Commit-Position: refs/heads/master@{#388475}
==========

[commit-bot: I haz the power, 2016-04-22 19:22:46]

Patchset 2 (id:??) landed as
https://crrev.com/5c0086b4a519d448e269ec3d558aacf4e2e86156
Cr-Commit-Position: refs/heads/master@{#388475}