Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Issue 1896423002: [NTP Snippets] Add tests for scheduling/unscheduling (Closed)

Created:
4 years, 8 months ago by Marc Treib
Modified:
4 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, mcwilliams+watch_chromium.org, dgn+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Add tests for scheduling/unscheduling BUG=595723 Committed: https://crrev.com/5c0086b4a519d448e269ec3d558aacf4e2e86156 Cr-Commit-Position: refs/heads/master@{#388475}

Patch Set 1 #

Total comments: 4

Patch Set 2 : remove empty ctor/dtor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -6 lines) Patch
M components/ntp_snippets/ntp_snippets_service_unittest.cc View 1 4 chunks +44 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896423002/1
4 years, 8 months ago (2016-04-20 09:50:12 UTC) #2
Marc Treib
PTAL!
4 years, 8 months ago (2016-04-20 09:50:20 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-20 10:26:10 UTC) #6
Bernhard Bauer
lgtm https://codereview.chromium.org/1896423002/diff/1/components/ntp_snippets/ntp_snippets_service_unittest.cc File components/ntp_snippets/ntp_snippets_service_unittest.cc (right): https://codereview.chromium.org/1896423002/diff/1/components/ntp_snippets/ntp_snippets_service_unittest.cc#newcode109 components/ntp_snippets/ntp_snippets_service_unittest.cc:109: MockScheduler() {} Nit: I would just remove the ...
4 years, 8 months ago (2016-04-20 11:25:57 UTC) #7
Marc Treib
https://codereview.chromium.org/1896423002/diff/1/components/ntp_snippets/ntp_snippets_service_unittest.cc File components/ntp_snippets/ntp_snippets_service_unittest.cc (right): https://codereview.chromium.org/1896423002/diff/1/components/ntp_snippets/ntp_snippets_service_unittest.cc#newcode109 components/ntp_snippets/ntp_snippets_service_unittest.cc:109: MockScheduler() {} On 2016/04/20 11:25:57, Bernhard Bauer wrote: > ...
4 years, 8 months ago (2016-04-20 12:03:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896423002/20001
4 years, 8 months ago (2016-04-20 12:03:16 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-20 12:44:00 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:22:46 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5c0086b4a519d448e269ec3d558aacf4e2e86156
Cr-Commit-Position: refs/heads/master@{#388475}

Powered by Google App Engine
This is Rietveld 408576698