Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: chrome/browser/prerender/prerender_unittest.cc

Issue 1896403002: Prerender: Remove MatchComplete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: re-enable PrerenderDeferredSynchronousXHR Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prerender/prerender_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_unittest.cc
diff --git a/chrome/browser/prerender/prerender_unittest.cc b/chrome/browser/prerender/prerender_unittest.cc
index ee3254a1d07e93a650a67a5ca1adc73fbc5ace39..890a37355988ffd1b248c58a627ff3a7aa490259 100644
--- a/chrome/browser/prerender/prerender_unittest.cc
+++ b/chrome/browser/prerender/prerender_unittest.cc
@@ -955,83 +955,6 @@ TEST_F(PrerenderTest, NotSoRecentlyVisited) {
ASSERT_EQ(prerender_contents, prerender_manager()->FindAndUseEntry(url));
}
-// Tests that our PPLT dummy prerender gets created properly.
-TEST_F(PrerenderTest, PPLTDummy) {
- RestorePrerenderMode restore_prerender_mode;
- PrerenderManager::SetMode(
- PrerenderManager::PRERENDER_MODE_EXPERIMENT_MATCH_COMPLETE_GROUP);
-
- GURL url("http://www.google.com/");
- DummyPrerenderContents* prerender_contents =
- prerender_manager()->CreateNextPrerenderContents(
- url, FINAL_STATUS_UNSUPPORTED_SCHEME);
- EXPECT_TRUE(AddSimplePrerender(url));
- EXPECT_TRUE(prerender_contents->prerendering_has_started());
- EXPECT_FALSE(IsEmptyPrerenderLinkManager());
-
- DummyPrerenderContents* pplt_dummy_contents =
- prerender_manager()->CreateNextPrerenderContents(url,
- FINAL_STATUS_USED);
- GURL ftp_url("ftp://ftp.google.com/");
- // Adding this ftp URL will force the expected unsupported scheme error.
- prerender_contents->AddAliasURL(ftp_url);
- EXPECT_FALSE(IsEmptyPrerenderLinkManager());
-
- ASSERT_EQ(pplt_dummy_contents, prerender_manager()->FindAndUseEntry(url));
- EXPECT_TRUE(IsEmptyPrerenderLinkManager());
-}
-
-// Tests that our PPLT dummy prerender gets created properly, even
-// when navigating to a page that has been recently navigated to.
-TEST_F(PrerenderTest, RecentlyVisitedPPLTDummy) {
- RestorePrerenderMode restore_prerender_mode;
- PrerenderManager::SetMode(
- PrerenderManager::PRERENDER_MODE_EXPERIMENT_MATCH_COMPLETE_GROUP);
-
- GURL url("http://www.google.com/");
- DummyPrerenderContents* prerender_contents =
- prerender_manager()->CreateNextPrerenderContents(
- url, FINAL_STATUS_UNSUPPORTED_SCHEME);
- EXPECT_TRUE(AddSimplePrerender(url));
- EXPECT_TRUE(prerender_contents->prerendering_has_started());
-
- DummyPrerenderContents* pplt_dummy_contents =
- prerender_manager()->CreateNextPrerenderContents(url,
- FINAL_STATUS_USED);
- prerender_manager()->RecordNavigation(url);
- GURL ftp_url("ftp://ftp.google.com/");
- prerender_contents->AddAliasURL(ftp_url);
-
- ASSERT_EQ(pplt_dummy_contents, prerender_manager()->FindAndUseEntry(url));
-}
-
-TEST_F(PrerenderTest, PPLTLateCancel) {
- RestorePrerenderMode restore_prerender_mode;
- PrerenderManager::SetMode(
- PrerenderManager::PRERENDER_MODE_EXPERIMENT_MATCH_COMPLETE_GROUP);
-
- GURL url("http://www.google.com");
- DummyPrerenderContents* prerender_contents =
- prerender_manager()->CreateNextPrerenderContents(
- url, FINAL_STATUS_JAVASCRIPT_ALERT);
- EXPECT_TRUE(AddSimplePrerender(url));
- EXPECT_TRUE(prerender_contents->prerendering_has_started());
- // Force the creation of a match complete dummy.
- DummyPrerenderContents* duplicate_prerender_contents =
- prerender_manager()->CreateNextPrerenderContents(url,
- FINAL_STATUS_CANCELLED);
- ASSERT_EQ(prerender_contents, prerender_manager()->FindEntry(url));
- prerender_contents->Destroy(FINAL_STATUS_JAVASCRIPT_ALERT);
- ASSERT_EQ(duplicate_prerender_contents, prerender_manager()->FindEntry(url));
-
- // Make sure that events on prerender handles propogate to the match
- // complete replacement.
- DummyPrerenderContents* null = NULL;
- prerender_link_manager()->OnCancelPrerender(kDefaultChildId,
- last_prerender_id());
- ASSERT_EQ(null, prerender_manager()->FindEntry(url));
-}
-
// Tests that the prerender manager matches include the fragment.
TEST_F(PrerenderTest, FragmentMatchesTest) {
GURL fragment_url("http://www.google.com/#test");
« no previous file with comments | « chrome/browser/prerender/prerender_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698