Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2791)

Unified Diff: chrome/browser/prerender/prerender_link_manager.cc

Issue 1896403002: Prerender: Remove MatchComplete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: re-enable PrerenderDeferredSynchronousXHR Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prerender/prerender_link_manager.h ('k') | chrome/browser/prerender/prerender_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_link_manager.cc
diff --git a/chrome/browser/prerender/prerender_link_manager.cc b/chrome/browser/prerender/prerender_link_manager.cc
index 9b1a232b17c1dd101eff0fbb45dc0e58db246f49..eff472bf6c4de91254661a0ec33747dc98c81a84 100644
--- a/chrome/browser/prerender/prerender_link_manager.cc
+++ b/chrome/browser/prerender/prerender_link_manager.cc
@@ -272,7 +272,6 @@ PrerenderLinkManager::LinkPrerender::LinkPrerender(
creation_time(creation_time),
deferred_launcher(deferred_launcher),
handle(NULL),
- is_match_complete_replacement(false),
has_been_abandoned(false) {}
PrerenderLinkManager::LinkPrerender::LinkPrerender(const LinkPrerender& other) =
@@ -521,29 +520,10 @@ void PrerenderLinkManager::OnPrerenderStop(
if (!prerender)
return;
- // If the prerender became a match complete replacement, the stop
- // message has already been sent.
- if (!prerender->is_match_complete_replacement) {
- Send(prerender->launcher_child_id,
- new PrerenderMsg_OnPrerenderStop(prerender->prerender_id));
- }
- RemovePrerender(prerender);
- StartPrerenders();
-}
-
-void PrerenderLinkManager::OnPrerenderCreatedMatchCompleteReplacement(
- PrerenderHandle* prerender_handle) {
- LinkPrerender* prerender = FindByPrerenderHandle(prerender_handle);
- if (!prerender)
- return;
-
- DCHECK(!prerender->is_match_complete_replacement);
- prerender->is_match_complete_replacement = true;
Send(prerender->launcher_child_id,
new PrerenderMsg_OnPrerenderStop(prerender->prerender_id));
- // Do not call RemovePrerender here. The replacement needs to stay connected
- // to the HTMLLinkElement in the renderer so it notices renderer-triggered
- // cancelations.
+ RemovePrerender(prerender);
+ StartPrerenders();
}
} // namespace prerender
« no previous file with comments | « chrome/browser/prerender/prerender_link_manager.h ('k') | chrome/browser/prerender/prerender_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698