Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3073)

Unified Diff: chrome/browser/prerender/prerender_contents.h

Issue 1896403002: Prerender: Remove MatchComplete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added TODO for MatchCompleteStatus Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_contents.h
diff --git a/chrome/browser/prerender/prerender_contents.h b/chrome/browser/prerender/prerender_contents.h
index 907128cb23844560411071788cb6e0035b29b4fb..725cd87d901ba3d769c69877529974a1d062806f 100644
--- a/chrome/browser/prerender/prerender_contents.h
+++ b/chrome/browser/prerender/prerender_contents.h
@@ -86,10 +86,6 @@ class PrerenderContents : public content::NotificationObserver,
// destroyed.
virtual void OnPrerenderStop(PrerenderContents* contents) = 0;
- // Signals that this prerender has just become a MatchComplete replacement.
- virtual void OnPrerenderCreatedMatchCompleteReplacement(
- PrerenderContents* contents, PrerenderContents* replacement);
-
protected:
Observer();
virtual ~Observer() = 0;
@@ -100,6 +96,8 @@ class PrerenderContents : public content::NotificationObserver,
// all prerenders and control group prerenders) or MatchComplete (record
// running prerenders only in the way they would have been recorded in the
// control group).
+ // TODO(pasko): Remove the deadcode associated with non-default
mmenke 2016/05/04 19:21:52 nit: "dead code"
pasko 2016/05/09 16:07:51 Done.
+ // MatchCompleteStatus.
enum MatchCompleteStatus {
// A regular prerender which will be recorded both in Match and
// MatchComplete.
@@ -285,8 +283,6 @@ class PrerenderContents : public content::NotificationObserver,
void NotifyPrerenderStopLoading();
void NotifyPrerenderDomContentLoaded();
void NotifyPrerenderStop();
- void NotifyPrerenderCreatedMatchCompleteReplacement(
- PrerenderContents* replacement);
// Called whenever a RenderViewHost is created for prerendering. Only called
// once the RenderViewHost has a RenderView and RenderWidgetHostView.

Powered by Google App Engine
This is Rietveld 408576698