Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1896343002: a few small dart:_runtime cleanups (Closed)

Created:
4 years, 8 months ago by Jennifer Messerly
Modified:
4 years, 8 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -51 lines) Patch
M lib/runtime/dart_sdk.js View 2 chunks +5 lines, -6 lines 0 comments Download
M test/codegen/expect/language-all.js View Binary file 0 comments Download
M tool/input_sdk/private/ddc_runtime/rtti.dart View 1 chunk +10 lines, -15 lines 0 comments Download
M tool/input_sdk/private/ddc_runtime/types.dart View 4 chunks +22 lines, -30 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
This fixes a few places that were easy to make use the consistent JS(...) style. ...
4 years, 8 months ago (2016-04-20 00:05:41 UTC) #2
vsm
lgtm
4 years, 8 months ago (2016-04-20 19:47:04 UTC) #3
Jennifer Messerly
4 years, 8 months ago (2016-04-20 19:52:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0399b84fa47f2f672fb0722b98593aef7ebed477 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698