Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: core/fpdftext/include/cpdf_linkextract.h

Issue 1896303002: Remove CFX_ArrayTemplate from CPDF_LinkExtract (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: No RVO for you. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/fpdftext/fpdf_text_int_unittest.cpp ('k') | core/fpdftext/include/cpdf_textpage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fpdftext/include/cpdf_linkextract.h
diff --git a/core/fpdftext/include/cpdf_linkextract.h b/core/fpdftext/include/cpdf_linkextract.h
index 263768ee5d05a7a2b57f033992889a163c498b4b..4f9537c79963f71ad9174c7aad993581324decab 100644
--- a/core/fpdftext/include/cpdf_linkextract.h
+++ b/core/fpdftext/include/cpdf_linkextract.h
@@ -7,6 +7,8 @@
#ifndef CORE_FPDFTEXT_INCLUDE_CPDF_LINKEXTRACT_H_
#define CORE_FPDFTEXT_INCLUDE_CPDF_LINKEXTRACT_H_
+#include <vector>
+
#include "core/fxcrt/include/fx_basic.h"
#include "core/fxcrt/include/fx_coordinates.h"
#include "core/fxcrt/include/fx_string.h"
@@ -14,41 +16,31 @@
class CPDF_TextPage;
-class CPDF_LinkExt {
- public:
- CPDF_LinkExt() {}
- ~CPDF_LinkExt() {}
-
- int m_Start;
- int m_Count;
- CFX_WideString m_strUrl;
-};
-
class CPDF_LinkExtract {
public:
- CPDF_LinkExtract();
+ explicit CPDF_LinkExtract(const CPDF_TextPage* pTextPage);
~CPDF_LinkExtract();
- FX_BOOL ExtractLinks(const CPDF_TextPage* pTextPage);
- int CountLinks() const;
- CFX_WideString GetURL(int index) const;
- void GetBoundedSegment(int index, int& start, int& count) const;
- void GetRects(int index, CFX_RectArray& rects) const;
-
- FX_BOOL IsExtract() const { return m_bIsParsed; }
+ void ExtractLinks();
+ size_t CountLinks() const { return m_LinkArray.size(); }
+ CFX_WideString GetURL(size_t index) const;
+ void GetRects(size_t index, CFX_RectArray* pRects) const;
protected:
void ParseLink();
- void DeleteLinkList();
- FX_BOOL CheckWebLink(CFX_WideString& strBeCheck);
+ bool CheckWebLink(CFX_WideString& str);
bool CheckMailLink(CFX_WideString& str);
- void AppendToLinkList(int start, int count, const CFX_WideString& strUrl);
private:
- CFX_ArrayTemplate<CPDF_LinkExt*> m_LinkList;
- const CPDF_TextPage* m_pTextPage;
+ struct Link {
+ int m_Start;
+ int m_Count;
+ CFX_WideString m_strUrl;
+ };
+
+ const CPDF_TextPage* const m_pTextPage;
CFX_WideString m_strPageText;
- bool m_bIsParsed;
+ std::vector<Link> m_LinkArray;
};
#endif // CORE_FPDFTEXT_INCLUDE_CPDF_LINKEXTRACT_H_
« no previous file with comments | « core/fpdftext/fpdf_text_int_unittest.cpp ('k') | core/fpdftext/include/cpdf_textpage.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698