Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1896293003: Pass the --module flag to test262 tests with modules enabled (Closed)

Created:
4 years, 8 months ago by Dan Ehrenberg
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Pass the --module flag to test262 tests with modules enabled This causes an incoming test262 test to pass, as part of the next test262 roll. R=adamk,machenbach BUG=v8:1569 LOG=N Committed: https://crrev.com/8b7b5a6f450966031665919f4f520a0a3a388138 Cr-Commit-Position: refs/heads/master@{#35667}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M test/test262/testcfg.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Dan Ehrenberg
4 years, 8 months ago (2016-04-20 01:34:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896293003/1
4 years, 8 months ago (2016-04-20 01:34:27 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-20 01:52:18 UTC) #5
Michael Achenbach
lgtm
4 years, 8 months ago (2016-04-20 07:33:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896293003/1
4 years, 8 months ago (2016-04-20 15:36:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 15:43:22 UTC) #10
nodir1
4 years, 8 months ago (2016-04-22 18:44:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b7b5a6f450966031665919f4f520a0a3a388138
Cr-Commit-Position: refs/heads/master@{#35667}

Powered by Google App Engine
This is Rietveld 408576698