Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(983)

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_page.js

Issue 1896283003: [MD settings] appearance theme and wallpaper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: param comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/appearance_page/appearance_page.js
diff --git a/chrome/browser/resources/settings/appearance_page/appearance_page.js b/chrome/browser/resources/settings/appearance_page/appearance_page.js
index c8320e907b5b9f6b5281a8f0e55d4f36683acc4e..b5d0f19833d9a90cb2f290771493ec55300a8bad 100644
--- a/chrome/browser/resources/settings/appearance_page/appearance_page.js
+++ b/chrome/browser/resources/settings/appearance_page/appearance_page.js
@@ -28,6 +28,9 @@ Polymer({
type: Object,
},
+ /** @private {!settings.AppearanceBrowserProxy} */
+ browserProxy_: Object,
+
/**
* Preferences state.
*/
@@ -111,6 +114,10 @@ Polymer({
'zoomLevelChanged_(defaultZoomLevel_.value)',
],
+ created: function() {
+ this.browserProxy_ = settings.AppearanceBrowserProxyImpl.getInstance();
+ },
+
ready: function() {
this.$.defaultFontSize.menuOptions = this.fontSizeOptions_;
this.$.pageZoom.menuOptions = this.pageZoomOptions_;
@@ -123,7 +130,7 @@ Polymer({
/** @override */
attached: function() {
// Query the initial state.
- cr.sendWithPromise('getResetThemeEnabled').then(
+ this.browserProxy_.getResetThemeEnabled().then(
this.setResetThemeEnabled.bind(this));
// Set up the change event listener.
@@ -160,9 +167,17 @@ Polymer({
window.open(loadTimeData.getString('themesGalleryUrl'));
},
+ /**
dpapad 2016/04/19 23:32:40 Same here, let's wrap with "if expr". I think you
dschuyler 2016/04/20 00:19:07 Done.
+ * ChromeOS only.
+ * @private
+ */
+ openWallpaperGallery_: function() {
dpapad 2016/04/19 23:32:40 Nit(optional): Gallery vs Manager, can we stick wi
dschuyler 2016/04/20 00:19:06 Done.
+ this.browserProxy_.openWallpaperManager();
+ },
+
/** @private */
resetTheme_: function() {
- chrome.send('resetTheme');
+ this.browserProxy_.resetTheme();
},
/** @private */

Powered by Google App Engine
This is Rietveld 408576698