[MD settings] appearance theme and wallpaper

chrome/test/data/webui/settings/appearance_page_test.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Runs polymer appearance font settings elements. */
 
 cr.define('settings_appearance', function() {
   /**
+   * A test version of AppearanceBrowserProxy.
+   *
+   * @constructor
+   * @implements {settings.AppearanceBrowserProxy}
+   * @extends {settings.TestBrowserProxy}
+   */
+  var TestAppearanceBrowserProxy = function() {
+    settings.TestBrowserProxy.call(this, [
+      'getResetThemeEnabled',
+      'openWallpaperManager',
+      'resetTheme',
+    ]);
+
+    this.allowResetTheme = false;

[dpapad, 2016/04/19 23:32:40]

Nit: @type {boolean}

[dschuyler, 2016/04/20 00:19:07]

Done.

+  };
+
+  TestAppearanceBrowserProxy.prototype = {
+    __proto__: settings.TestBrowserProxy.prototype,
+
+    /** @override */
+    getResetThemeEnabled: function() {
+      this.methodCalled('getResetThemeEnabled');
+      return Promise.resolve(this.allowResetTheme);
+    },
+
+    /** @override */
+    openWallpaperManager: function() {
+      this.methodCalled('openWallpaperManager');
+    },
+
+    /** @override */
+    resetTheme: function() {
+      this.methodCalled('resetTheme');
+    },
+
+    setAllowResetTheme: function(isEnabled) {
+      this.allowResetTheme = isEnabled;
+      cr.webUIListenerCallback('reset-theme-enabled-changed', isEnabled);
+      Polymer.dom.flush();
+    }
+  };
+
+  /**
    * A test version of FontsBrowserProxy.
    *
    * @constructor
    * @implements {settings.FontsBrowserProxy}
    * @extends {settings.TestBrowserProxy}
    */
   var TestFontsBrowserProxy = function() {
     settings.TestBrowserProxy.call(this, [
       'fetchFontsData',
       'observeAdvancedFontExtensionAvailable',
+      'openAdvancedFontSettings',
     ]);
 
     /** @private {!FontsData} */
     this.fontsData_ = {
       'fontList': [['font name', 'alternate', 'ltr']],
       'encodingList': [['encoding name', 'alternate', 'ltr']],
     };
   };
 
   TestFontsBrowserProxy.prototype = {
     __proto__: settings.TestBrowserProxy.prototype,
 
     /** @override */
     fetchFontsData: function() {
       this.methodCalled('fetchFontsData');
       return Promise.resolve(this.fontsData_);
     },
 
     /** @override */
     observeAdvancedFontExtensionAvailable: function() {
       this.methodCalled('observeAdvancedFontExtensionAvailable');
     },
+
+    /** @override */
+    openAdvancedFontSettings: function() {
+      this.methodCalled('openAdvancedFontSettings');
+    },
   };
 
+  function registerAppearanceSettingsBrowserTest() {
+    var appearancePage = null;
+
+    /** @type {?TestAppearanceBrowserProxy} */
+    var appearanceBrowserProxy = null;
+
+    suite('AppearanceHandler', function() {
+      setup(function() {
+        appearanceBrowserProxy = new TestAppearanceBrowserProxy();
+        settings.AppearanceBrowserProxyImpl.instance_ = appearanceBrowserProxy;
+
+        PolymerTest.clearBody();
+
+        appearancePage = document.createElement('settings-appearance-page');
+        document.body.appendChild(appearancePage);
+
+        return Promise.all([
+          PolymerTest.importHtml('chrome://md-settings/i18n_setup.html'),

[dpapad, 2016/04/19 23:32:40]

Is this necessary? Can it be added as a dependency to appearance_page.html
instead?

[dschuyler, 2016/04/20 00:19:07]

Done.

+        ]);
+      });
+
+      teardown(function() { appearancePage.remove(); });
+
+      if (cr.isChromeOS) {
+        test('wallpaperManager', function() {
+          var button = appearancePage.$$('#wallpaperButton');

[dpapad, 2016/04/19 23:32:40]

Nit: Does the following work?

var button = appearancePage.$.wallpaperButton;

[dschuyler, 2016/04/20 00:19:07]

Done.

+          assert(!!button);

[dpapad, 2016/04/19 23:32:40]

Nit(optional): assertTrue(!!button).

Effectively assert() and assertTrue() both check for the same thing, but
assert() is used to ensure production code invariants hold, where as
assertTrue() is more appropriate for testing code IMO.

Similarly, I suggest assertFalse(!!someElement) instead of assert(!someElement),
for the reason mentioned above, but also because the double negation
(counter-intuitively) makes the code more readable if it is used everywhere,
consider

assertFalse(!!element2);
vs
assert(!element2);

The former produces an error message that is closer to what we are actually
checking.

[dschuyler, 2016/04/20 00:19:07]

Done.

+          MockInteractions.tap(button);
+          return appearanceBrowserProxy.whenCalled('openWallpaperManager');
+        });
+      } else {
+        test('noWallpaperManager', function() {
+          // The wallpaper button should not be present.
+          var button = appearancePage.$$('#wallpaperButton');
+          assert(!button);
+        });
+      }
+
+      test('resetTheme', function() {
+        appearanceBrowserProxy.setAllowResetTheme(true);
+        var button = appearancePage.$$('#resetTheme');
+        assert(!!button);
+        MockInteractions.tap(button);
+        return appearanceBrowserProxy.whenCalled('resetTheme');
+      });
+    });
+  }
+
   function registerAppearanceFontSettingsBrowserTest() {
     var fontsPage = null;
 
     /** @type {?TestFontsBrowserProxy} */
     var fontsBrowserProxy = null;
 
     suite('AppearanceFontHandler', function() {
       setup(function() {
         fontsBrowserProxy = new TestFontsBrowserProxy();
         settings.FontsBrowserProxyImpl.instance_ = fontsBrowserProxy;
 
         PolymerTest.clearBody();
 
         fontsPage = document.createElement('settings-appearance-fonts-page');
         document.body.appendChild(fontsPage);
       });
 
       teardown(function() { fontsPage.remove(); });
 
       test('fetchFontsData', function() {
         return fontsBrowserProxy.whenCalled('fetchFontsData');
       });
+
+      test('openAdvancedFontSettings', function() {
+        cr.webUIListenerCallback('advanced-font-settings-installed', [true]);
+        Polymer.dom.flush();
+        var button = fontsPage.$$('#advancedButton');
+        assert(!!button);
+        MockInteractions.tap(button);
+        return fontsBrowserProxy.whenCalled('openAdvancedFontSettings');
+      });
     });
   }
 
   return {
     registerTests: function() {
       registerAppearanceFontSettingsBrowserTest();
+      registerAppearanceSettingsBrowserTest();
     },
   };
 });