Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1896283002: Make Blob constructor's first argument optional. (Closed)

Created:
4 years, 8 months ago by jsbell
Modified:
4 years, 8 months ago
Reviewers:
philipj_slow
CC:
chromium-reviews, blink-reviews, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Blob constructor's first argument optional. The spec previously had constructor overloads, allowing blobs to be created with either `new Blob()` (no arguments) or `new Blob([data])` (argument with array of blob parts). But unlike most APIs, calling as `new Blob(undefined)` would throw, which is unexpected. The spec was updated to remove the overload and make the first argument optional instead. A PR has been submitted to update web-platform-tests. Spec: https://w3c.github.io/FileAPI/ BUG=604910 R=philipj@opera.com Committed: https://crrev.com/7dfcdc193f42dc9d5adfb4048fd0fc66c9f06bd5 Cr-Commit-Position: refs/heads/master@{#388806}

Patch Set 1 #

Patch Set 2 : Update imported test results #

Patch Set 3 : Update platform-specific expectations #

Messages

Total messages: 13 (6 generated)
jsbell
philipj@ - please take a look?
4 years, 8 months ago (2016-04-20 19:09:29 UTC) #2
philipj_slow
lgtm
4 years, 8 months ago (2016-04-21 08:46:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896283002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896283002/40001
4 years, 8 months ago (2016-04-21 08:46:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/162552)
4 years, 8 months ago (2016-04-21 08:56:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896283002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896283002/40001
4 years, 8 months ago (2016-04-21 16:21:56 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-21 17:40:42 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:35:53 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7dfcdc193f42dc9d5adfb4048fd0fc66c9f06bd5
Cr-Commit-Position: refs/heads/master@{#388806}

Powered by Google App Engine
This is Rietveld 408576698