Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1896243002:
Fix repaint overlay in layout test results (Closed)
DescriptionFix repaint overlay in layout test results
This fixes broken repaint overlay (visualization of paint invalidation
rects) in layout test results due to recent format change of layer tree
paint invalidation info.
The unit test shows how the format changed.
BUG=602483
Committed: https://crrev.com/b5458f271cb0780413bb0bfbb3b712ef718ac338
Cr-Commit-Position: refs/heads/master@{#388406}
Patch Set 1 #Patch Set 2 : #
Messages
Total messages: 22 (12 generated)
Description was changed from ========== Fix repaint overlay in layout test results BUG=602843 ========== to ========== Fix repaint overlay in layout test results This fixes broken repaint overlay (visualization of paint invalidation rects) in layout test results due to recent format change of layer tree paint invalidation info. BUG=602843 ==========
wangxianzhu@chromium.org changed reviewers: + chrishtr@chromium.org, wkorman@chromium.org
Description was changed from ========== Fix repaint overlay in layout test results This fixes broken repaint overlay (visualization of paint invalidation rects) in layout test results due to recent format change of layer tree paint invalidation info. BUG=602843 ========== to ========== Fix repaint overlay in layout test results This fixes broken repaint overlay (visualization of paint invalidation rects) in layout test results due to recent format change of layer tree paint invalidation info. The unit test shows how the format changed. BUG=602843 ==========
lgtm The bug number looks like it may be wrong?
Description was changed from ========== Fix repaint overlay in layout test results This fixes broken repaint overlay (visualization of paint invalidation rects) in layout test results due to recent format change of layer tree paint invalidation info. The unit test shows how the format changed. BUG=602843 ========== to ========== Fix repaint overlay in layout test results This fixes broken repaint overlay (visualization of paint invalidation rects) in layout test results due to recent format change of layer tree paint invalidation info. The unit test shows how the format changed. BUG=602483 ==========
On 2016/04/19 20:51:48, wkorman wrote: > lgtm > > The bug number looks like it may be wrong? Should be 602483. Fixed.
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896243002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896243002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by wangxianzhu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org Link to the patchset: https://codereview.chromium.org/1896243002/#ps20001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896243002/20001
Message was sent while issue was closed.
Description was changed from ========== Fix repaint overlay in layout test results This fixes broken repaint overlay (visualization of paint invalidation rects) in layout test results due to recent format change of layer tree paint invalidation info. The unit test shows how the format changed. BUG=602483 ========== to ========== Fix repaint overlay in layout test results This fixes broken repaint overlay (visualization of paint invalidation rects) in layout test results due to recent format change of layer tree paint invalidation info. The unit test shows how the format changed. BUG=602483 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix repaint overlay in layout test results This fixes broken repaint overlay (visualization of paint invalidation rects) in layout test results due to recent format change of layer tree paint invalidation info. The unit test shows how the format changed. BUG=602483 ========== to ========== Fix repaint overlay in layout test results This fixes broken repaint overlay (visualization of paint invalidation rects) in layout test results due to recent format change of layer tree paint invalidation info. The unit test shows how the format changed. BUG=602483 Committed: https://crrev.com/b5458f271cb0780413bb0bfbb3b712ef718ac338 Cr-Commit-Position: refs/heads/master@{#388406} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b5458f271cb0780413bb0bfbb3b712ef718ac338 Cr-Commit-Position: refs/heads/master@{#388406} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
