Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Issue 1896233002: Minor style cleanup in DockedWindowLayoutManager (Closed)

Created:
4 years, 8 months ago by sky
Modified:
4 years, 8 months ago
Reviewers:
varkha
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor style cleanup in DockedWindowLayoutManager Moves WindowWithHeight to .cc, removes '_' from struct member names and removes accessors. BUG=603369 TEST=none R=varkha@chromium.org Committed: https://crrev.com/5f9242260c2077161b4c3dd7e14112544c122a97 Cr-Commit-Position: refs/heads/master@{#388299}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -30 lines) Patch
M ash/wm/dock/docked_window_layout_manager.h View 2 chunks +4 lines, -10 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager.cc View 9 chunks +27 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
4 years, 8 months ago (2016-04-19 19:49:20 UTC) #1
varkha
lgtm. Thanks!
4 years, 8 months ago (2016-04-19 20:04:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896233002/1
4 years, 8 months ago (2016-04-19 20:22:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-19 20:37:04 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:15:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f9242260c2077161b4c3dd7e14112544c122a97
Cr-Commit-Position: refs/heads/master@{#388299}

Powered by Google App Engine
This is Rietveld 408576698