Throw DataCloneError on cloning closed Blobs/Files.

Throw DataCloneError on cloning closed Blobs/Files.

Follow the structured cloning spec and disallow cloning of closed Blobs,

 http://www.whatwg.org/specs/web-apps/current-work/#structured-clone

R=mkwst@chromium.org
BUG=344820
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168746

[sof, 2014-03-07 13:19:37]

When you have a moment, please take a look.

[Mike West, 2014-03-07 13:28:13]

LGTM with nits, thanks for bringing this up to spec.

https://codereview.chromium.org/189623014/diff/1/LayoutTests/fast/dom/Window/...
File LayoutTests/fast/dom/Window/script-tests/postmessage-clone.js (right):

https://codereview.chromium.org/189623014/diff/1/LayoutTests/fast/dom/Window/...
LayoutTests/fast/dom/Window/script-tests/postmessage-clone.js:88:
tryPostMessage('constructedFile.close(); constructedFile', true, null,
DOMException.DATA_CLONE_ERR);
This isn't pretty. I'm not a fan of test code that leans this heavily on eval...
:/

Ah well, no reason not to land this change.

https://codereview.chromium.org/189623014/diff/1/Source/bindings/v8/Serialize...
File Source/bindings/v8/SerializedScriptValue.cpp (right):

https://codereview.chromium.org/189623014/diff/1/Source/bindings/v8/Serialize...
Source/bindings/v8/SerializedScriptValue.cpp:1061: return
handleError(DataCloneError, "A Blob object could not be cloned.", next);
Could you be more specific in the error message here? Perhaps something like
"The Blob object is closed, and therefore may not be cloned."

https://codereview.chromium.org/189623014/diff/1/Source/bindings/v8/Serialize...
Source/bindings/v8/SerializedScriptValue.cpp:1084: return
handleError(DataCloneError, "A File object could not be cloned.", next);
Ditto.

[sof, 2014-03-07 13:34:31]

https://codereview.chromium.org/189623014/diff/1/LayoutTests/fast/dom/Window/...
File LayoutTests/fast/dom/Window/script-tests/postmessage-clone.js (right):

https://codereview.chromium.org/189623014/diff/1/LayoutTests/fast/dom/Window/...
LayoutTests/fast/dom/Window/script-tests/postmessage-clone.js:88:
tryPostMessage('constructedFile.close(); constructedFile', true, null,
DOMException.DATA_CLONE_ERR);
On 2014/03/07 13:28:13, Mike West wrote:
> This isn't pretty. I'm not a fan of test code that leans this heavily on
eval...
> :/
> 
> Ah well, no reason not to land this change.

That's the test setup in this file.

https://codereview.chromium.org/189623014/diff/1/Source/bindings/v8/Serialize...
File Source/bindings/v8/SerializedScriptValue.cpp (right):

https://codereview.chromium.org/189623014/diff/1/Source/bindings/v8/Serialize...
Source/bindings/v8/SerializedScriptValue.cpp:1061: return
handleError(DataCloneError, "A Blob object could not be cloned.", next);
On 2014/03/07 13:28:13, Mike West wrote:
> Could you be more specific in the error message here? Perhaps something like
> "The Blob object is closed, and therefore may not be cloned."

Done.

https://codereview.chromium.org/189623014/diff/1/Source/bindings/v8/Serialize...
Source/bindings/v8/SerializedScriptValue.cpp:1084: return
handleError(DataCloneError, "A File object could not be cloned.", next);
On 2014/03/07 13:28:13, Mike West wrote:
> Ditto.

Done.

[sof, 2014-03-07 13:34:47]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-03-07 13:35:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sigbjornf@opera.com/189623014/20001

[commit-bot: I haz the power, 2014-03-07 13:52:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-07 13:52:00]

Try jobs failed on following builders: linux_blink

[sof, 2014-03-07 14:16:42]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-03-07 14:17:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sigbjornf@opera.com/189623014/20001

[commit-bot: I haz the power, 2014-03-07 14:29:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-07 14:29:08]

Try jobs failed on following builders: win_blink_rel

[sof, 2014-03-07 14:32:33]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-03-07 14:33:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sigbjornf@opera.com/189623014/20001

[commit-bot: I haz the power, 2014-03-07 15:29:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-07 15:29:48]

Try jobs failed on following builders: linux_blink

[sof, 2014-03-07 15:34:20]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-03-07 15:34:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sigbjornf@opera.com/189623014/20001

[commit-bot: I haz the power, 2014-03-07 16:29:32]

Change committed as 168746